-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cpu/gd32v: add periph_rtc_mem support #19254
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gschorcht
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
smlng,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
February 6, 2023 21:26
github-actions
bot
added
Area: cpu
Area: CPU/MCU ports
Area: Kconfig
Area: Kconfig integration
Area: tests
Area: tests and testing framework
labels
Feb 6, 2023
gschorcht
added
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: RISC-V
Platform: This PR/issue effects RISC-V-based platforms
labels
Feb 6, 2023
benpicco
approved these changes
Feb 7, 2023
bors merge |
With this PR the GD32V support is almost complete. Still missing are only |
bors bot
added a commit
that referenced
this pull request
Feb 7, 2023
17045: sys/coding: add XOR based coding module r=benpicco a=benpicco 19251: tests/driver_dac_dds: fix output of sine and saw functions r=benpicco a=benpicco 19254: cpu/gd32v: add periph_rtc_mem support r=benpicco a=gschorcht ### Contribution description This PR provides the `periph_rtc_mem` support for GD32VF103. A modified version of this driver could also be used for STM32F1. ### Testing procedure `tests/periph_rtt` should work on any GD32V board, for example: ``` BOARD=sipeed-longan-nano make -C tests/periph_rtt flash ``` ``` Help: Press s to start test, r to print it is ready START main(): This is RIOT! (Version: 2023.04-devel-319-gebc86-cpu/gd32v/periph_rtc_mem) RIOT RTT low-level driver test RTT configuration: RTT_MAX_VALUE: 0xffffffff RTT_FREQUENCY: 32768 Testing the tick conversion Trying to convert 1 to seconds and back Trying to convert 256 to seconds and back Trying to convert 65536 to seconds and back Trying to convert 16777216 to seconds and back Trying to convert 2147483648 to seconds and back All ok Initializing the RTT driver RTC mem OK This test will now display 'Hello' every 5 seconds RTT now: 1 Setting initial alarm to now + 5 s (163841) rtt_get_alarm() PASSED RTC mem OK ``` ### Issues/PRs references Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com> Co-authored-by: Gunar Schorcht <gunar@schorcht.net>
Build failed (retrying...): |
Build succeeded: |
Thanks for reviewing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: cpu
Area: CPU/MCU ports
Area: Kconfig
Area: Kconfig integration
Area: tests
Area: tests and testing framework
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: RISC-V
Platform: This PR/issue effects RISC-V-based platforms
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR provides the
periph_rtc_mem
support for GD32VF103.A modified version of this driver could also be used for STM32F1.
Testing procedure
tests/periph_rtt
should work on any GD32V board, for example:Issues/PRs references