drivers: add support for MTDs emulated in RAM #19443

gschorcht · 2023-04-03T10:03:27Z

Contribution description

This PR adds a driver to provide MTDs that are emulated in RAM. It allows to test MTD-based applications on boards that do not provide MTDs by hardware.

It includes also some small documentation fixes for mtd.h that were found while writing the driver.

Testing procedure

The following tests should work on any board:

tests/pkg_littlefs
tests/pkg_littlefs2
tests/pkg_spiffs

Issues/PRs references

riot-ci · 2023-04-03T11:40:33Z

Murdock results

✔️ PASSED

89f18c7 tests/littlefs: remove blacklisted boards due to reduced sector count

Success	Failures	Total	Runtime
6882	0	6882	10m:02s

Artifacts

Documentation preview

dylad

Quick round of review.
I didn't test it yet.

drivers/mtd_emulated/Kconfig

drivers/include/mtd.h

drivers/mtd_emulated/Kconfig

dylad · 2023-04-07T19:29:20Z

@gschorcht Please squash !

dylad

spotted this on lastest commit

tests/usbus_msc/README.md

19460: cpu/stm32/usbdev_fs: fix ep registration and EP_REG assignments r=gschorcht a=dylad ### Contribution description This PR provides two fixes for the `usbdev_fs` driver: - Fix endpoints registration - Fix assignment of toggleable bits in EP_REG(x) registers These bugs were encountered with the USBUS MSC implementation. Regarding the endpoints registration: For the `usbdev_fs` peripheral, IN and OUT endpoints of the same index must have the same type. For instance, if EP1 OUT is a bulk endpoint, EP1 IN must either be unused or used as bulk too but it cannot be used as interrupt or isochronous. With the previous check, the following registration pattern (EP OUT Bulk -> EP IN Interrupt -> EP IN Bulk) would assign both EP OUT Bulk and EP IN Interrupt to same endpoint index. So the configuration would be broken. Applying the same registration pattern with this patch would now produce EP OUT Bulk -> 1 / EP IN Interrupt -> 2 / EP IN Bulk 1. Which is a working configuration for this IP. and for the second fix: EP_REG(x) registers have a total of 6 toggleable bits. Those bits can only be toggled if we write a one to it, otherwise writing a zero has no effect This commit fixes all the access to these registers to prevent from modifying these bits when not needed. Without this patch, the endpoint status (VALID / NACK / STALL) can be erroneously modify because bits are not cleared when assigning the new content to the register and thus make the bits toggle and change values. ### Testing procedure This can be tested with tests/usbus_msc on any board using this `usbdev_fs` driver. It is easier to test this PR with #19443 alongside. Then the following would be enough: `CFLAGS='-DSECTOR_COUNT=64' USEMODULE='mtd_emulated' make -j8 BOARD=p-nucleo-wb55 -C tests/usbus_msc flash` Otherwise this can also be tested by attaching a SPI<->SDCARD adapter. ### Issues/PRs references None. Co-authored-by: Dylan Laduranty <dylan.laduranty@mesotic.com>

dylad

Please squash (including these two nitpicks)

drivers/include/mtd_default.h

drivers/include/mtd_emulated.h

gschorcht · 2023-04-11T07:08:55Z

Squashed

This driver provides support for MTDs emulated in RAM to test MTD-based applications on boards that do not provide MTDs in hardware.

dylad

CI complains about unittests.

tests/unittests/tests-mtd/tests-mtd.c

dylad

ACK.

dylad · 2023-04-12T07:07:40Z

bors merge

19443: drivers: add support for MTDs emulated in RAM r=dylad a=gschorcht ### Contribution description This PR adds a driver to provide MTDs that are emulated in RAM. It allows to test MTD-based applications on boards that do not provide MTDs by hardware. It includes also some small documentation fixes for `mtd.h` that were found while writing the driver. ### Testing procedure The following tests should work on any board: `tests/pkg_littlefs` `tests/pkg_littlefs2` `tests/pkg_spiffs` ### Issues/PRs references Co-authored-by: Gunar Schorcht <gunar@schorcht.net>

bors · 2023-04-12T08:34:39Z

Build failed:

Murdock

A `SECTOR_COUNT` of 12 seems to be sufficient to work for this test in emulated MTD.

Removing boards blacklisted for insufficient memory after reducing the number of sectors of the emulated MTD.

dylad · 2023-04-12T09:57:02Z

bors merge

bors · 2023-04-12T12:01:49Z

Build succeeded:

gschorcht · 2023-04-12T12:19:28Z

Thanks

19465: drivers/mtd: use XFA for pointers to defined MTDs r=benpicco a=gschorcht ### Contribution description This PR provides the support to hold pointers to defined MTDs within a XFA. The XFA allows - to access MTDs of different types (`mtd_flashpage`, `mtd_sdcard`, `mtd_emulated`, ...) by an index - to determine the number of MTDs defined in the system. ### Testing procedure To be defined once PR #19443 is merged because emulated MTDs will allow to test this PR on arbitrary boards. ### Porting Guide For external boards: - remove the `MTD_NUMOF` definition from `board.h` - add `MTD_XFA_ADD(<mtd_dev>, <idx>);` to the definition of `<mtd_dev>`. - `MTD_0`, `MTD_1`, … defines are no longer needed. ### Issues/PRs references Related to PR #19443 19981: Fletcher32: Add incremental API r=benpicco a=bergzand ### Contribution description This PR extends the current fletcher32 checksum with an incremental API mode. This way the bytes to be checksummed can be supplied via multiple successive calls and do not have to be provided in a single consecutive buffer. I've also rephrased the warning with the original function a bit as that function uses an `unaligned_get_u16` to access the data. The data thus does not require alignment, but the length does need to be supplied as number of 16 bit words. ### Testing procedure The test has been extended ### Issues/PRs references None 19995: sys/psa_crypto: Fix macro for public key max size and SE example r=benpicco a=Einhornhool ### Contribution description #### 1. Wrong public key size when using secure elements, introduced by #19954 Fixed conditions for key size macros in `crypto_sizes.h`. #### 2. EdDSA and ECDSA examples fail when using a secure element because of unsopported changes introduced by #19954 Updated `example/psa_crypto` to use only supported functions for secure elements. ### Testing procedure Build `example/psa_crypto` for secure elements and run application Output on master: ``` 2023-10-19 14:33:24,372 # main(): This is RIOT! (Version: 2019.07-devel-22378-gb6772) 2023-10-19 14:33:24,372 # HMAC SHA256 took 56393 us 2023-10-19 14:33:24,372 # Cipher AES 128 took 68826 us 2023-10-19 14:33:24,372 # *** RIOT kernel panic: 2023-10-19 14:33:24,373 # HARD FAULT HANDLER 2023-10-19 14:33:24,373 # 2023-10-19 14:33:24,373 # *** rebooting... ``` Output with fixes: ``` 2023-10-19 13:35:24,715 # main(): This is RIOT! (Version: 2019.07-devel-22384-g8ef66-dev/psa-crypto-fixes) 2023-10-19 13:35:24,715 # HMAC SHA256 took 56374 us 2023-10-19 13:35:24,715 # Cipher AES 128 took 68805 us 2023-10-19 13:35:24,715 # ECDSA took 281164 us 2023-10-19 13:35:24,715 # All Done ``` Co-authored-by: Gunar Schorcht <gunar@schorcht.net> Co-authored-by: Koen Zandberg <koen@bergzand.net> Co-authored-by: Lena Boeckmann <lena.boeckmann@haw-hamburg.de>

gschorcht requested review from leandrolanzieri, jia200x, MrKevinWeiss, smlng, aabadie, MichelRottleuthner and fjmolinas as code owners April 3, 2023 10:03

github-actions bot added Area: drivers Area: Device drivers Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework labels Apr 3, 2023

gschorcht force-pushed the drivers/mtd_emulated branch from 0401d1b to bf98644 Compare April 3, 2023 10:04

gschorcht added Type: new feature The issue requests / The PR implemements a new feature for RIOT CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Apr 3, 2023

gschorcht changed the title ~~Drivers/mtd emulated~~ drivers: add support for MTDs emulated in RAM Apr 3, 2023

dylad reviewed Apr 4, 2023

View reviewed changes

dylad mentioned this pull request Apr 7, 2023

cpu/stm32/usbdev_fs: fix ep registration and EP_REG assignments #19460

Merged

github-actions bot added the Area: doc Area: Documentation label Apr 8, 2023

dylad reviewed Apr 8, 2023

View reviewed changes

tests/usbus_msc/README.md Outdated Show resolved Hide resolved

tests/usbus_msc/README.md Outdated Show resolved Hide resolved

dylad requested a review from benpicco April 10, 2023 19:29

dylad reviewed Apr 10, 2023

View reviewed changes

drivers/include/mtd_default.h Outdated Show resolved Hide resolved

drivers/include/mtd_emulated.h Outdated Show resolved Hide resolved

gschorcht force-pushed the drivers/mtd_emulated branch from 43f12e9 to 7ea26f7 Compare April 11, 2023 06:55

gschorcht requested a review from miri64 as a code owner April 11, 2023 06:55

gschorcht force-pushed the drivers/mtd_emulated branch from 7ea26f7 to a03d416 Compare April 11, 2023 06:57

gschorcht added 2 commits April 11, 2023 17:42

drivers/mtd: small fixes in doc

7561973

drivers/mtd_emulatd: MTD emulated in RAM for testing

609c090

This driver provides support for MTDs emulated in RAM to test MTD-based applications on boards that do not provide MTDs in hardware.

gschorcht force-pushed the drivers/mtd_emulated branch from a03d416 to 816caf7 Compare April 11, 2023 15:47

gschorcht mentioned this pull request Apr 11, 2023

drivers/mtd: use XFA for pointers to defined MTDs #19465

Merged

dylad requested changes Apr 11, 2023

View reviewed changes

tests/unittests/tests-mtd/tests-mtd.c Outdated Show resolved Hide resolved

gschorcht added 6 commits April 12, 2023 06:27

tests/unittests/test-mtd: use emulated MTD as test mockup

0cdcac9

tests/littlefs: use emulated MTD as test mockup

af5b75a

tests/littlefs2: use emulated MTD as test mockup

f724f34

tests/spiffs: use emulated MTD as test mockup

631df7c

tests/usbus_msc: use emulated MTD as test mockup

4bb283c

drivers/mtd_default: expose one SD Card and one MTD emulated

1d4d3e4

gschorcht force-pushed the drivers/mtd_emulated branch from 816caf7 to 1d4d3e4 Compare April 12, 2023 04:37

dylad approved these changes Apr 12, 2023

View reviewed changes

gschorcht added 2 commits April 12, 2023 11:23

tests/littlefs: reduce sector count for emulated MTD

4af1fa6

A `SECTOR_COUNT` of 12 seems to be sufficient to work for this test in emulated MTD.

tests/littlefs: remove blacklisted boards due to reduced sector count

89f18c7

Removing boards blacklisted for insufficient memory after reducing the number of sectors of the emulated MTD.

bors bot merged commit b342cdc into RIOT-OS:master Apr 12, 2023

gschorcht deleted the drivers/mtd_emulated branch April 12, 2023 12:19

benpicco added this to the Release 2023.07 milestone Aug 2, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

drivers: add support for MTDs emulated in RAM #19443

drivers: add support for MTDs emulated in RAM #19443

gschorcht commented Apr 3, 2023

riot-ci commented Apr 3, 2023 •

edited

Loading

dylad left a comment

dylad commented Apr 7, 2023

dylad left a comment

dylad left a comment

gschorcht commented Apr 11, 2023

dylad left a comment

dylad left a comment

dylad commented Apr 12, 2023

bors bot commented Apr 12, 2023

dylad commented Apr 12, 2023

bors bot commented Apr 12, 2023

gschorcht commented Apr 12, 2023

drivers: add support for MTDs emulated in RAM #19443

drivers: add support for MTDs emulated in RAM #19443

Conversation

gschorcht commented Apr 3, 2023

Contribution description

Testing procedure

Issues/PRs references

riot-ci commented Apr 3, 2023 • edited Loading

Murdock results

Artifacts

dylad left a comment

Choose a reason for hiding this comment

dylad commented Apr 7, 2023

dylad left a comment

Choose a reason for hiding this comment

dylad left a comment

Choose a reason for hiding this comment

gschorcht commented Apr 11, 2023

dylad left a comment

Choose a reason for hiding this comment

dylad left a comment

Choose a reason for hiding this comment

dylad commented Apr 12, 2023

bors bot commented Apr 12, 2023

dylad commented Apr 12, 2023

bors bot commented Apr 12, 2023

gschorcht commented Apr 12, 2023

riot-ci commented Apr 3, 2023 •

edited

Loading