Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys /cpp11-compat: remove pseudo anonymous namespaces #19477

Merged
merged 1 commit into from
May 4, 2023
Merged

sys /cpp11-compat: remove pseudo anonymous namespaces #19477

merged 1 commit into from
May 4, 2023

Conversation

kfessel
Copy link
Contributor

@kfessel kfessel commented Apr 17, 2023 •
edited
Loading

Contribution description

remove pseudo anonymous namespaces in favor of defines that are used thoughout the rest of riot

Testing procedure

cpp test do not fail

Issues/PRs references

@github-actions github-actions bot added the Area: sys Area: System label Apr 17, 2023
@kfessel kfessel added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: low priority If set, builds of this PR will be queued behind others and removed Area: sys Area: System labels Apr 17, 2023
@github-actions github-actions bot added the Area: sys Area: System label Apr 17, 2023
@riot-ci
Copy link

riot-ci commented Apr 17, 2023 •
edited
Loading

Murdock results

✔️ PASSED

da17ebb sys /cpp11-compat: remove pseudo anonymous namespaces

Success Failures Total Runtime
6882 0 6882 10m:18s

Artifacts

@kfessel kfessel marked this pull request as ready for review May 4, 2023 11:42
@MrKevinWeiss MrKevinWeiss added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label May 4, 2023
MrKevinWeiss
MrKevinWeiss approved these changes May 4, 2023
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess we don't need the abstraction. If murdock passes then it should be fine. ACK!

@MrKevinWeiss
Copy link
Contributor

bors merge

@bors
Copy link
Contributor

bors bot commented May 4, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 26c61be into RIOT-OS:master May 4, 2023
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@kaspar030 kaspar030 Awaiting requested review from kaspar030

Assignees
No one assigned
Labels
Area: sys Area: System CI: low priority If set, builds of this PR will be queued behind others CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
4 participants
@kfessel @riot-ci @MrKevinWeiss @benpicco