Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

board: add Adafruit Grand Central M4 Express support #19580

Merged
merged 1 commit into from
Jun 9, 2023
Merged

board: add Adafruit Grand Central M4 Express support #19580

merged 1 commit into from
Jun 9, 2023

Conversation

gschorcht
Copy link
Contributor

Contribution description

This PR provides the support for Adafruit Grand Central M4 Express board. The main features of the board are:

  • ATSAMD51 Cortex M4 running at 120 MHz
  • 1MB Flash
  • 256 KB RAM
  • external 8 MB QSPI Flash storage
  • Micro SD Card slot connected to SPI

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: boards Area: Board ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration labels May 11, 2023
aabadie
aabadie reviewed May 12, 2023
View reviewed changes
boards/adafruit-grand-central-m4-express/include/board.h Outdated
extern mtd_dev_t *mtd1; /**< MTD device pointer for SD Card */
#define MTD_1 mtd1 /**< MTD device for SD Card */

#define CONFIG_SDCARD_GENERIC_MTD_OFFSET 1
Copy link
Contributor

@aabadie aabadie May 12, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing the static tests (undocumented)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry I forgot to label the PR as WIP 😉

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first sight, it didn't seem so WIP, that's why I briefly looked at it :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it is actually almost finished, I just wanted to have a look at the timer configuration and the PWM configuration again and test it.

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 12, 2023
@riot-ci
Copy link

riot-ci commented May 12, 2023 •
edited
Loading

Murdock results

✔️ PASSED

3d9d93e board: add Adafruit Grand Central M4 Express support

Success Failures Total Runtime
531 0 531 03m:29s

Artifacts

@gschorcht gschorcht added the State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet label May 12, 2023
benpicco
benpicco reviewed Jun 1, 2023
View reviewed changes
boards/adafruit-grand-central-m4-express/Kconfig Outdated
config BOARD
default "adafruit-grand-central-m4-expres" if BOARD_ADAFRUIT_GRAND_CENTRAL_M4_EXPRES

config BOARD_ADAFRUIT_GRAND_CENTRAL_M4_EXPRES
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
config BOARD_ADAFRUIT_GRAND_CENTRAL_M4_EXPRES
config BOARD_ADAFRUIT_GRAND_CENTRAL_M4_EXPRESS

@gschorcht gschorcht force-pushed the boards/adafruit-grand-central-m4-express branch from 0ef5d90 to c83af3f Compare June 9, 2023 13:12
benpicco
benpicco approved these changes Jun 9, 2023
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, please squash

@gschorcht gschorcht force-pushed the boards/adafruit-grand-central-m4-express branch from e656edb to 3d9d93e Compare June 9, 2023 14:28
@maribu
Copy link
Member

maribu commented Jun 9, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 0e09b43 into RIOT-OS:master Jun 9, 2023
@gschorcht
Copy link
Contributor Author

Thanks for reviewing and merging.

@gschorcht gschorcht deleted the boards/adafruit-grand-central-m4-express branch June 10, 2023 16:03
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie left review comments

@benpicco benpicco benpicco approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss MrKevinWeiss is a code owner

Assignees
No one assigned
Labels
Area: boards Area: Board ports Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR State: WIP State: The PR is still work-in-progress and its code is not in its final presentable form yet
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
5 participants
@gschorcht @riot-ci @maribu @benpicco @aabadie