Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys: add some missing kconfig + adapt related tests when possible #19622

Merged
merged 8 commits into from
May 20, 2023
Merged

sys: add some missing kconfig + adapt related tests when possible #19622

merged 8 commits into from
May 20, 2023

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented May 19, 2023 •
edited
Loading

Contribution description

tests/sys/sema_inv is also adapted to use ztimer instead of xtimer.
coding, uuid and ut_process are only tested in unittests which is not adapted to Kconfig. uuid is also used by suit but this is not adapted to Kconfig yet.

Testing procedure

  • Green CI
  • tests/sys/sema_inv and tests/sys/ssp can also be built without errors using TEST_KCONFIG=1

Issues/PRs references

split-out from #19492
#16875

@aabadie aabadie added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 19, 2023
@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework labels May 19, 2023
@riot-ci
Copy link

riot-ci commented May 19, 2023

Murdock results

✔️ PASSED

12a6ed0 tests/sys/ssp: add kconfig dependency file

Success Failures Total Runtime
6945 0 6945 10m:26s

Artifacts

MrKevinWeiss
MrKevinWeiss approved these changes May 20, 2023
View reviewed changes
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would worry a bit about uuid as the random module is not always straightforward but something is better than nothing and I think it isn't too risky.

Everything else looks good.

ACK

@aabadie
Copy link
Contributor Author

aabadie commented May 20, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented May 20, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 975f150 into RIOT-OS:master May 20, 2023
@aabadie aabadie deleted the pr/sys/add_some_kconfig branch May 20, 2023 12:47
@aabadie aabadie mentioned this pull request May 20, 2023
Merged
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKevinWeiss MrKevinWeiss MrKevinWeiss approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@smlng smlng Awaiting requested review from smlng

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
4 participants
@aabadie @riot-ci @MrKevinWeiss @benpicco