Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/isrpipe: Replace xtimer with ztimer_usec #19645

Merged
merged 3 commits into from
Jun 8, 2023
Merged

sys/isrpipe: Replace xtimer with ztimer_usec #19645

merged 3 commits into from
Jun 8, 2023

Conversation

MrKevinWeiss
Copy link
Contributor

Contribution description

Getting ready for the xtimer dep.

Testing procedure

Green murdock, there is no explicit test for isrpipe but since it runs xtimer compat it should operate the same.

Issues/PRs references

@MrKevinWeiss MrKevinWeiss requested a review from aabadie May 22, 2023 11:30
@github-actions github-actions bot added Area: Kconfig Area: Kconfig integration Area: sys Area: System labels May 22, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 22, 2023
@riot-ci
Copy link

riot-ci commented May 22, 2023 •
edited
Loading

Murdock results

✔️ PASSED

b618db2 tests/sys/fido2_ctap: Replace ztimer with ztimer_sec

Success Failures Total Runtime
6933 0 6933 14m:00s

Artifacts

@github-actions github-actions bot added the Area: tests Area: tests and testing framework label May 23, 2023
@miri64
Copy link
Member

miri64 commented May 23, 2023

After looking into it, I see that isrpipe_read_timeout is a dependency of a lot of packets, so I now think that should be done as a follow-up, but I doubt, that it really needs microsecond precision for its timeout. So later: Move all dependent modules to millisecond precision and use ztimer_msec instead.

@MrKevinWeiss MrKevinWeiss added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 24, 2023
@MrKevinWeiss
Copy link
Contributor Author

bors try

bors bot added a commit that referenced this pull request May 30, 2023
@bors
Try #19645:
b7627f1
@MrKevinWeiss
Copy link
Contributor Author

I don't know why the murdock status doesn't update...

@aabadie
Copy link
Contributor

aabadie commented May 30, 2023

don't know why the murdock status doesn't update...

I think Murdock must be green first

@aabadie
Copy link
Contributor

aabadie commented May 30, 2023

There's still one failure reported by the fast Murdock: https://ci.riot-os.org/results/28d4565788e04d38891ec591e8dfbdf0/output/builds/tests/sys/fido2_ctap/samr21-xpro:gnu.txt

@bors
Copy link
Contributor

bors bot commented May 30, 2023

try

Build failed:

@benpicco
Copy link
Contributor

benpicco commented Jun 8, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Jun 8, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 2268caa into RIOT-OS:master Jun 8, 2023
@MrKevinWeiss MrKevinWeiss deleted the pr/isrpipe branch June 9, 2023 12:57
@benpicco benpicco added this to the Release 2023.07 milestone Aug 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aabadie aabadie aabadie left review comments

@maribu maribu maribu approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@jia200x jia200x Awaiting requested review from jia200x jia200x is a code owner

@smlng smlng Awaiting requested review from smlng

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

@fjmolinas fjmolinas Awaiting requested review from fjmolinas

Assignees
No one assigned
Labels
Area: Kconfig Area: Kconfig integration Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.07
Development

Successfully merging this pull request may close these issues.
6 participants
@MrKevinWeiss @riot-ci @miri64 @aabadie @benpicco @maribu