-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
stdio_dispatch: allow to select multiple stdio methods at the same time #19738
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benpicco
requested review from
bergzand,
dylad,
aabadie,
miri64,
haukepetersen,
PeterKietzmann,
cgundogan and
gschorcht
as code owners
June 16, 2023 13:59
github-actions
bot
added
Area: build system
Area: Build system
Area: cpu
Area: CPU/MCU ports
Area: network
Area: Networking
Area: pkg
Area: External package ports
Area: sys
Area: System
Area: USB
Area: Universal Serial Bus
Platform: ESP
Platform: This PR/issue effects ESP-based platforms
labels
Jun 16, 2023
benpicco
changed the title
Stdio dispatch
stdio_dispatch: allow to select multiple stdio methods at the same time
Jun 16, 2023
benpicco
force-pushed
the
stdio_dispatch
branch
2 times, most recently
from
June 16, 2023 14:22
6e03795
to
fe4b248
Compare
miri64
reviewed
Jun 16, 2023
benpicco
force-pushed
the
stdio_dispatch
branch
from
February 2, 2024 10:01
083a0fd
to
ae3ae3d
Compare
benpicco
force-pushed
the
stdio_dispatch
branch
from
February 2, 2024 10:51
ae3ae3d
to
c5c7fab
Compare
benpicco
added
the
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
label
Feb 2, 2024
This is now ready for review again. |
benpicco
force-pushed
the
stdio_dispatch
branch
from
February 2, 2024 11:29
87ac088
to
3849257
Compare
benpicco
force-pushed
the
stdio_dispatch
branch
from
February 9, 2024 14:31
7d91af4
to
018b732
Compare
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 9, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: build system
Area: Build system
Area: cpu
Area: CPU/MCU ports
Area: drivers
Area: Device drivers
Area: network
Area: Networking
Area: pkg
Area: External package ports
Area: sys
Area: System
Area: USB
Area: Universal Serial Bus
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Platform: ESP
Platform: This PR/issue effects ESP-based platforms
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This implements the option to have multiple stdio methods active at the same time.
This can be useful to allow e.g. remote debugging while also retaining the possibility for local shell access.
To implement this, all
stdin
implementations are expected to write to a commonstdin_isrpipe
.Two stdio providers have not been converted to the new interface yet, that means they can't be combined with a second stdio method:
stdio_native
: depends on cpu/native: use async read for stdio_read() #19002slipdev_stdio
: depends on drivers/slipdev: make use of chunked ringbuffer #18066stdio_ethos
: requires a similar patch asslipdev_stdio
If only a single stdio method is used, the function pointer/XFA based interface degrades into the traditional in-place implementations of
stdio_init()
/stdio_write()
to avoid introducing any overhead in the common case.Testing procedure
It is now possible to select multiple stdio implementations and use them all at the same time:
Issues/PRs references
fixes #13469