drivers/shield_w5100: add module for the W5100 Ethernet Shield #19764
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Type: new feature
maribu
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
aabadie,
dylad,
fjmolinas,
gschorcht and
basilfx
as code owners
github-actions
bot
added
Area: doc
github-actions
bot
removed
the
Area: toolchain
Rather than providing this for every board (or group of boards) individually, it is better to provide this once relying on the Arduino I/O mapping features.
github-actions
bot
removed
Area: tests
maribu
removed
Area: build system
github-actions
bot
added
Area: build system
|
Doccheck isn't happy, otherwise looks good |
This module provides no more than the correct configuration parameters for the `w5100` driver using the Arduino I/O mapping features. But by doing so, it will work out of the box with every mechanically and electrically compatible board for which the Arduino I/O mapping features are implemented.
benpicco
approved these changes
Jul 10, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
|
thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This module provides no more than the correct configuration parameters for the
w5100driver using the Arduino I/O mapping features. But by doing so, it will work out of the box with every mechanically and electrically compatible board for which the Arduino I/O mapping features are implemented.Testing procedure
Should just work. And it should also work e.g. for the Arduino MEGA2560 or the Arduino Zero. By adding Arduino I/O mapping features to the nRF52840DK, this should also work there.
Issues/PRs references
Depends on #19759