dist/tools/usb-serial: call ttys.py with its path [backport 2023.07] #19831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
added
Area: tools
benpicco
approved these changes
Jul 14, 2023
|
bors merge |
|
Build succeeded! The publicly hosted instance of bors-ng is deprecated and will go away soon. If you want to self-host your own instance, instructions are here. If you want to switch to GitHub's built-in merge queue, visit their help page. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #19823
Contribution description
This PR provides a fix for #19805
When calling
SERIAL=xxx make flashthe command failed because the scriptdist/tools/usb-serial/find-ttys.shtries to callttys.pybut it doesn't find it. So pass the full path tottys.pyto get rid of the problem.Testing procedure
Connect at least two boards to your computer
run
make list-ttysto get the ID of your boardsTry to flash one of them with (replace SERIAL with the one you get with the previous command):
BOARD=xxx SERIAL=xxx make -C tests/leds flashIt fails on master.
It should works with this PR.
Issues/PRs references
Fixes #19805