Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ztimer/periodic: no reinit #19832

Closed
wants to merge 1 commit into from

Conversation

kfessel
Copy link
Contributor

@kfessel kfessel commented Jul 14, 2023

Contribution description

this returns early when reinit

Testing procedure

Issues/PRs references

Fixes #19806 the lean way (reinit is not allowed but if it happens we return early, restart is not allowed (aquire count will be wrong) restop is not allowed (aquire count will be wrong)

@kfessel
Copy link
Contributor Author

kfessel commented Jul 14, 2023

I just saw restart is documented and just was just broken when using ztimer_aquire/release (since it isn't tracking correctly unless the same number for starts and stops happen)

* When called on an already running timer, the current interval is reset to its

@benpicco
Copy link
Contributor

Is this still needed?

@kfessel
Copy link
Contributor Author

kfessel commented Aug 1, 2023

solved by #19826

@kfessel kfessel closed this Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System Area: timers Area: timer subsystems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants