Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/gcoap_fileserver: add zep_dispatcher to TEST_DEPS #19864

Merged
merged 4 commits into from
Aug 9, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Aug 8, 2023

Contribution description

The test needs zep_dispatch to run.
Without it the nodes can't communicate.

Testing procedure

CI should no longer fail because test is started while TERMDEPS are still being built.

Issues/PRs references

@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Aug 8, 2023
@github-actions github-actions bot added Area: tests Area: tests and testing framework and removed Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Aug 8, 2023
@riot-ci
Copy link

riot-ci commented Aug 8, 2023

Murdock results

✔️ PASSED

094f7f0 tests/gnrc_sixlowpan_frag_sfr_congure_impl: zep_dispatcher to TEST_DEPS

Success Failures Total Runtime
81 0 81 02m:04s

Artifacts

@benpicco benpicco requested a review from miri64 as a code owner August 8, 2023 20:31
@benpicco benpicco force-pushed the tests/net/gcoap_fileserver-race branch from 24c725a to 094f7f0 Compare August 8, 2023 20:32
@benpicco benpicco requested a review from gschorcht August 8, 2023 20:33
@benpicco benpicco added the Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) label Aug 8, 2023
@benpicco
Copy link
Contributor Author

benpicco commented Aug 8, 2023

bors merge

let's hope CI is less finicky now

bors bot added a commit that referenced this pull request Aug 8, 2023
19864: tests/gcoap_fileserver: add zep_dispatcher to TEST_DEPS r=benpicco a=benpicco



Co-authored-by: Benjamin Valentin <benjamin.valentin@ml-pa.com>
@bors
Copy link
Contributor

bors bot commented Aug 8, 2023

Build failed:

@benpicco
Copy link
Contributor Author

benpicco commented Aug 9, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 91441db into RIOT-OS:master Aug 9, 2023
25 checks passed
@benpicco benpicco deleted the tests/net/gcoap_fileserver-race branch August 9, 2023 20:02
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants