Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make: COMPILE_COMMANDS_PATH adapt for external apps #19869

Merged
merged 1 commit into from
Aug 9, 2023
Merged

make: COMPILE_COMMANDS_PATH adapt for external apps #19869

merged 1 commit into from
Aug 9, 2023

Conversation

kfessel
Copy link
Contributor

@kfessel kfessel commented Aug 9, 2023

Contribution description

COMPILE_COMMANDS_PATH currently defaults to RIOTBASE which may not be an parent path for external applications -> set to APPDIR in case

Testing procedure

  • current good will stay good
    test with riot examples and or testes $make compile-commands should create a compile_command.json in <RIOT>

  • test with external app Makefile including
    include $(RIOTBASE)/Makefile.include
    should create compile_command.json in APPDIR

Issues/PRs references

@github-actions github-actions bot added the Area: build system Area: Build system label Aug 9, 2023
@benpicco benpicco requested a review from maribu August 9, 2023 13:22
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Aug 9, 2023
@riot-ci
Copy link

riot-ci commented Aug 9, 2023 •
edited
Loading

Murdock results

✔️ PASSED

d4d9be5 make: COMPILE_COMMANDS_PATH adapt for external apps

Success Failures Total Runtime
7907 0 7907 12m:37s

Artifacts

@benpicco
Copy link
Contributor

benpicco commented Aug 9, 2023

bors merge

@bors
Copy link
Contributor

bors bot commented Aug 9, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit 91441db into RIOT-OS:master Aug 9, 2023
27 checks passed
@MrKevinWeiss MrKevinWeiss added this to the Release 2023.10 milestone Nov 17, 2023
@kfessel kfessel mentioned this pull request May 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2023.10
Development

Successfully merging this pull request may close these issues.
5 participants
@kfessel @riot-ci @benpicco @maribu @MrKevinWeiss