Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

coap: create typedef for CoAP methods #20003

Merged
merged 2 commits into from
Nov 2, 2023
Merged

coap: create typedef for CoAP methods #20003

merged 2 commits into from
Nov 2, 2023

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Oct 20, 2023 •
edited
Loading

Contribution description

Avoid confusion between COAP_PUT and COAP_METHOD_PUT by creating a type for the latter.

Testing procedure

Shuld result in no change in the binary.

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Oct 20, 2023
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Oct 20, 2023
@riot-ci
Copy link

riot-ci commented Oct 20, 2023 •
edited
Loading

Murdock results

✔️ PASSED

db3294a nanocoap_sock: make use of coap_method_t

Success Failures Total Runtime
7953 0 7953 17m:32s

Artifacts

@benpicco benpicco added the Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation label Oct 20, 2023
bergzand
bergzand requested changes Oct 26, 2023
View reviewed changes
sys/include/net/coap.h Outdated Show resolved Hide resolved
bergzand
bergzand approved these changes Nov 2, 2023
View reviewed changes
Copy link
Member

@bergzand bergzand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ack

@benpicco
Copy link
Contributor Author

benpicco commented Nov 2, 2023

bors merge

@bors bors
Copy link
Contributor

bors bot commented Nov 2, 2023

Build succeeded!

The publicly hosted instance of bors-ng is deprecated and will go away soon.

If you want to self-host your own instance, instructions are here.
For more help, visit the forum.

If you want to switch to GitHub's built-in merge queue, visit their help page.

@bors bors bot merged commit c0ae75b into RIOT-OS:master Nov 2, 2023
26 checks passed
@benpicco benpicco deleted the coap_method_t branch November 2, 2023 15:50
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bergzand bergzand bergzand approved these changes

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2024.01
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @bergzand @MrKevinWeiss