boards/nucleo-wl55jc: Fix Arduino SPI bus #20085
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The macro `ARDUINO_SPI_D11D12D13` is used to refer to the SPI bus on the pins D11/D12/D13 on Arduino UNO compatible boards. For all Nucleo64 boards this is `SPI_DEV(0)`, but for this board `SPI_DEV(0)` is internally connected to the radio. Instead `SPI_DEV(1)` is connected to the correct pins. This provides the macro explicitly in `periph_conf.h`, which takes preference over the fallback in `boards/common/nucleo64` when provided.
maribu
added
Type: bug
benpicco
approved these changes
Nov 14, 2023
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
The macro
ARDUINO_SPI_D11D12D13is used to refer to the SPI bus on the pins D11/D12/D13 on Arduino UNO compatible boards. For all Nucleo64 boards this isSPI_DEV(0), but for this boardSPI_DEV(0)is internally connected to the radio. InsteadSPI_DEV(1)is connected to the correct pins. This provides the macro explicitly inperiph_conf.h, which takes preference over the fallback inboards/common/nucleo64when provided.Testing procedure
Check the lines above the macro in
periph_conf.hand confirm that the GPIO pins match the Arduino pin names.Or run the peripheral self test using the shield. With this, it hopefully passes.
Issues/PRs references
None