tests/periph/selftest_shield: improve SPI test #20089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fix a copy-paste error (`TIMER_FREQ_UART_TEST` was used in the SPI test, but that should be `TIMER_FREQ_SPI_TEST`) - use 400 kHz as slow SPI frequency, as faster STM32 MCUs just cannot divide the APB clock down to 100 kHz - when detailed output is enabled, print the SPI clock in addition to the SPI mode to ease figuring out what went wrong - only have one `FAILURE` message for a too fast byte transfer per check, rather than per transmitted byte, to reduce the noise - work around a bug of `periph_timer` on STM32 by reducing the clock speed of the timer for the SPI test
maribu
added
Type: bug
maribu
requested review from
smlng,
leandrolanzieri,
aabadie,
MichelRottleuthner and
fjmolinas
as code owners
15 tasks
benpicco
approved these changes
Nov 16, 2023
|
Thx :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
TIMER_FREQ_UART_TESTwas used in the SPI test, but that should beTIMER_FREQ_SPI_TEST)FAILUREmessage for a too fast byte transfer per check, rather than per transmitted byte, to reduce the noiseperiph_timeron STM32 by reducing the clock speed of the timer for the SPI testTesting procedure
This should fix the failure of the test on the Nucleo-F446RE.
Issues/PRs references
None