tests/unittests/tests-hashes: fix wrong string length #20165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fzi-haxel
force-pushed
the
pr/tests-hashes-sha512-fix
branch
from
f1efa99 to
8db9811
Compare
fzi-haxel
force-pushed
the
pr/tests-hashes-sha512-fix
branch
from
8db9811 to
4a1d07a
Compare
fzi-haxel
added a commit
to fzi-haxel/RIOT
that referenced
this pull request
Dec 11, 2023
Created separate PR (RIOT-OS#20165) This reverts commit 055471a.
benpicco
added
Type: bug
benpicco
approved these changes
Dec 11, 2023
fzi-haxel
added a commit
to fzi-haxel/RIOT
that referenced
this pull request
Dec 12, 2023
Created separate PR (RIOT-OS#20165) This reverts commit 055471a.
OlegHahm
pushed a commit
to OlegHahm/RIOT
that referenced
this pull request
Dec 13, 2023
Created separate PR (RIOT-OS#20165) This reverts commit 055471a.
OlegHahm
pushed a commit
to OlegHahm/RIOT
that referenced
this pull request
Dec 13, 2023
Created separate PR (RIOT-OS#20165) This reverts commit 055471a.
OlegHahm
pushed a commit
to OlegHahm/RIOT
that referenced
this pull request
Dec 21, 2023
Created separate PR (RIOT-OS#20165) This reverts commit 055471a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Incorrect use of
sizeoffor string length in testtest_hashes_sha512_hash_update_twice.static const char *teststringis a pointer, thereforesizeof(teststring)returns the pointer size instead of the intended string length.This PR usesstrleninstead ofsizeofto fix this. Alternatively, we could change the type of the string tostatic const char teststring[].Note the subtle difference betweensizeof(char[])andstrlen: The former includes the null terminator, whilestrlendoes not. This should not change the test behavior.Edit:
This PR changes the type to
static const char teststring[]so thatsizeofreturns the string length (including the null terminator).Testing procedure
Compile and run unittests.
Note for 32-bit architectures: The test also passed before, but only used 4 and 3+1 bytes of the string.