Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests/build_system: drop Kconfig tests #20229

Merged

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Jan 4, 2024

Contribution description

We don't need those anymore.

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: Kconfig Area: Kconfig integration labels Jan 4, 2024
@benpicco benpicco added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: tests Area: tests and testing framework Area: Kconfig Area: Kconfig integration CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Area: doc Area: Documentation Area: tests Area: tests and testing framework Area: Kconfig Area: Kconfig integration labels Jan 4, 2024
Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we only should drop the features test, the basic Kconfig test is for configurations only.

@benpicco benpicco force-pushed the tests/build_system-drop_kconfig branch from 9d2ad67 to b3254c3 Compare January 4, 2024 14:37
We are removing Kconfig dependency modeling, so the test is obsolete.
@github-actions github-actions bot added the Area: doc Area: Documentation label Jan 4, 2024
@benpicco benpicco force-pushed the tests/build_system-drop_kconfig branch from b3254c3 to bca6d27 Compare January 4, 2024 14:38
@riot-ci
Copy link

riot-ci commented Jan 4, 2024

Murdock results

✔️ PASSED

bca6d27 tests/build_system/kconfig_features: drop test

Success Failures Total Runtime
8085 0 8085 10m:18s

Artifacts

Copy link
Contributor

@MrKevinWeiss MrKevinWeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@MrKevinWeiss MrKevinWeiss added this pull request to the merge queue Jan 5, 2024
Merged via the queue into RIOT-OS:master with commit 32af575 Jan 5, 2024
26 checks passed
@benpicco benpicco deleted the tests/build_system-drop_kconfig branch January 5, 2024 10:46
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: doc Area: Documentation Area: Kconfig Area: Kconfig integration Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants