Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gnrc/nib: allow prefix to be on-link without being used for address #20243

Merged
merged 1 commit into from
Jan 11, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

A prefix might be on-link without us using it for a address on that prefix.

Testing procedure

Configure the address fdea:dbee:f::1 on a host in the network.
On a RIOT node in the same network, execute

nib prefix add 6 fdea:dbee:f::1/128

The host should now be reachable through that address.

Issues/PRs references

@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Jan 10, 2024
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 10, 2024
@riot-ci
Copy link

riot-ci commented Jan 10, 2024

Murdock results

✔️ PASSED

433438c gnrc/nib: allow prefix to be on-link without being used for address

Success Failures Total Runtime
8084 0 8085 11m:35s

Artifacts

@benpicco benpicco removed the Area: sys Area: System label Jan 10, 2024
@miri64
Copy link
Member

miri64 commented Jan 10, 2024

I know we discussed this in Matrix, but come to think of it: Why don't you just set the default route?

@benpicco
Copy link
Contributor Author

What if fdea:dbee:f::1 is not the default router?

@miri64
Copy link
Member

miri64 commented Jan 10, 2024

Got it!

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense to me, after some discussion.

@benpicco benpicco added this pull request to the merge queue Jan 10, 2024
Merged via the queue into RIOT-OS:master with commit bb4c4dd Jan 11, 2024
28 checks passed
@benpicco benpicco deleted the gnrc_ipv6_nib_pl_set-relax branch January 11, 2024 07:00
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: network Area: Networking CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants