Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: fix murdock tests after dwq change #20268

Merged
merged 2 commits into from
Jan 17, 2024
Merged

ci: fix murdock tests after dwq change #20268

merged 2 commits into from
Jan 17, 2024

Conversation

kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Jan 17, 2024 •
edited
Loading

Contribution description

With RIOT-OS/riotdocker#237 I broke murdock tests on the pifleet. This should fix them.

edit

So what happened here is that dwq dropped support for specifying the target path of a file sent along with a job.
That feature might come back.

In the meantime, this PR makes BINDIR match on compiler (mobi*, breeze, ...) and tester (pifleet).

(I've piggybacked a commit that makes the tester fail early if flashing returned an error code.)

Testing procedure

Issues/PRs references

@kaspar030 kaspar030 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: CI Area: Continuous Integration of RIOT components CI: run tests If set, CI server will run tests on hardware for the labeled PR CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before labels Jan 17, 2024
@riot-ci
Copy link

riot-ci commented Jan 17, 2024 •
edited
Loading

Murdock results

✔️ PASSED

c84400e ci: adapt .murdock test_job to changed dwq

Success Failures Total Runtime
8126 0 8126 11m:18s

Artifacts

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 17, 2024
@kaspar030 kaspar030 added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 17, 2024
@kaspar030
Copy link
Contributor Author

Test failure was IMO unrelated: https://ci.riot-os.org/details/07c9eaaf954c48a29f29315634954c10/tests

@kaspar030 kaspar030 added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: disable test cache If set, CI will always run all tests regardless of whether they have been run successfully before CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jan 17, 2024
@kaspar030 kaspar030 added this pull request to the merge queue Jan 17, 2024
Merged via the queue into RIOT-OS:master with commit de7d72c Jan 17, 2024
30 checks passed
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.01 milestone Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@benpicco benpicco benpicco approved these changes

Assignees
No one assigned
Labels
Area: CI Area: Continuous Integration of RIOT components CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR CI: run tests If set, CI server will run tests on hardware for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2024.01
Development

Successfully merging this pull request may close these issues.
5 participants
@kaspar030 @riot-ci @benpicco @maribu @MrKevinWeiss