dist/tools/mspdebug: build from source #20345
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds mspdebug as package, similar to EDBG, so that the programmer/debugger is build from source. This has the advantage that we can indeed provide patches of our own. The first patch fixes a bug with the CPU detection of `mspdebug` in combination with the Olimex MSP430-JTAG-TINY-V2. The second adds the `--expect-id <CPU_NAME>` argument. The RIOT integration is updated to directly make use of the `--expect-id` parameter. No more spending time debugging why firmware the firmware for the `olimex-msp430-h2618` doesn't run when flashed on the `olimex-msp430h1611` hardware :D
maribu
added
Type: new feature
|
With the (OK, |
|
With the |
benpicco
approved these changes
Feb 6, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
|
Thx :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This adds mspdebug as package, similar to EDBG, so that the programmer/debugger is build from source.
This has the advantage that we can indeed provide patches of our own. The first patch fixes a bug with the CPU detection of
mspdebugin combination with the Olimex MSP430-JTAG-TINY-V2. The second adds the--expect-id <CPU_NAME>argument.The RIOT integration is updated to directly make use of the
--expect-idparameter. No more spending time debugging why firmware the firmware for theolimex-msp430-h2618doesn't run when flashed on theolimex-msp430h1611hardware :DTesting procedure
Connect an MSP430 board to the Olimex MSP430-JTAG-TINY-V2, subsequently named
CORRECT_MSP430_BOARD. DO NOT connectWRONG_MSP430_BOARD(any other MSP430 board but the one connected).The following should now fail with this PR, while it won't fail on
master:The following should still work (did also work on
master):Finally, flashing and debugging should work even without
mspdebuginstalled locally.Issues/PRs references
None