Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

always use nanocoap_resources instead of manually assembling coap_resources[] #20374

Merged
merged 3 commits into from
Feb 12, 2024
Merged

always use nanocoap_resources instead of manually assembling coap_resources[] #20374

merged 3 commits into from
Feb 12, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

We now have XFA helpers to assemble the coap_resources[] array, convert the legacy examples.

Testing procedure

The same CoAP endpoints are still provided, but in a more user friendly way.

Issues/PRs references

@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: examples Area: Example Applications labels Feb 12, 2024
@benpicco benpicco added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Area: CoAP Area: Constrained Application Protocol implementations labels Feb 12, 2024
@riot-ci
Copy link

riot-ci commented Feb 12, 2024

Murdock results

✔️ PASSED

2dd6a65 tests/riotboot_flashwrite: make use of nanocoap_resources

Success Failures Total Runtime
26 0 26 01m:20s

Artifacts

mguetschow
mguetschow approved these changes Feb 12, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@benpicco benpicco added this pull request to the merge queue Feb 12, 2024
Merged via the queue into RIOT-OS:master with commit 597b2ad Feb 12, 2024
29 checks passed
@benpicco benpicco deleted the coap_resources_numof-remove branch February 12, 2024 16:09
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

@leandrolanzieri leandrolanzieri Awaiting requested review from leandrolanzieri leandrolanzieri is a code owner

@aabadie aabadie Awaiting requested review from aabadie aabadie is a code owner

@MichelRottleuthner MichelRottleuthner Awaiting requested review from MichelRottleuthner MichelRottleuthner is a code owner

Assignees
No one assigned
Labels
Area: CoAP Area: Constrained Application Protocol implementations Area: examples Area: Example Applications Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @mguetschow @MrKevinWeiss