Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gnrc_ipv6_nib: Ignore PIO with on-link flag #20418

Merged
merged 1 commit into from
Feb 23, 2024
Merged

gnrc_ipv6_nib: Ignore PIO with on-link flag #20418

merged 1 commit into from
Feb 23, 2024

Conversation

xnumad
Copy link
Contributor

@xnumad xnumad commented Feb 22, 2024

Contribution description

This PR directly addresses the changes suggested in #20377

Testing procedure

Tests are adjusted accordingly.

Issues/PRs references

Fixes #20377

@github-actions github-actions bot added Area: network Area: Networking Area: tests Area: tests and testing framework Area: sys Area: System labels Feb 22, 2024
benpicco
benpicco reviewed Feb 22, 2024
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!
Just a small formatting suggestion:

sys/net/gnrc/network_layer/ipv6/nib/nib.c Outdated Show resolved Hide resolved
@benpicco
Copy link
Contributor

Please squash!

@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Feb 22, 2024
benpicco
benpicco approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@benpicco benpicco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I gave it a quick test on native, examples/gnrc_networking (with USE_ZEP=1) still gets a prefix from examples/gnrc_border_router.

@riot-ci
Copy link

riot-ci commented Feb 22, 2024 •
edited
Loading

Murdock results

✔️ PASSED

23d3ccd gnrc_ipv6_nib: Ignore PIO with on-link flag

Success Failures Total Runtime
9997 0 9997 10m:12s

Artifacts

@benpicco benpicco added this pull request to the merge queue Feb 22, 2024
Merged via the queue into RIOT-OS:master with commit 0b385c6 Feb 23, 2024
25 checks passed
@MrKevinWeiss MrKevinWeiss added this to the Release 2024.04 milestone Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benpicco benpicco benpicco approved these changes

@miri64 miri64 Awaiting requested review from miri64 miri64 is a code owner

@PeterKietzmann PeterKietzmann Awaiting requested review from PeterKietzmann PeterKietzmann is a code owner

@fabian18 fabian18 Awaiting requested review from fabian18

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Milestone
Release 2024.04
Development

Successfully merging this pull request may close these issues.

6ln RA PIO with L flag set is not ignored
4 participants
@xnumad @benpicco @riot-ci @MrKevinWeiss