examples/psa_crypto: pass environment variable down to docker #20663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maribu
approved these changes
May 10, 2024
mguetschow
added
the
CI: ready for build
Maybe we can find a way to automate this (i.e. that the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
examples/psa_cryptouses a custom environment variable to specify the presence of a secure element. When building within Docker, this environment variable needs to be explicitly passed down.Testing procedure
make -C examples/psa_crypto BOARD=nrf52840dk SECURE_ELEMENT=1 BUILD_IN_DOCKER=1fails onmasterand compiles fine with this fix.Issues/PRs references
Another instance of #20618. Maybe it's worth checking all the example applications for similar issues.