Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sys/psa_crypto: remove keysize determination from Kconfig files #20674

Merged
merged 1 commit into from
May 16, 2024

Conversation

mguetschow
Copy link
Contributor

Contribution description

There were some left-overs from Kconfig dependency modeling (#20438) in the PSA crypto implementation, namely the determination of the maximum key size. This PR removes that and now also unconditionally sets the maximum key size in the C header file.

Testing procedure

Look at the changes, CI should do.

Issues/PRs references

Noted thanks to a discussion with @darthdrannel

@github-actions github-actions bot added the Area: sys Area: System label May 16, 2024
@mguetschow mguetschow added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label May 16, 2024
Copy link
Contributor

@Einhornhool Einhornhool left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine with it.
I manually ran some of the psa tests and they pass.

@mguetschow mguetschow enabled auto-merge May 16, 2024 11:22
@riot-ci
Copy link

riot-ci commented May 16, 2024

Murdock results

✔️ PASSED

6f5f431 sys/psa_crypto: remove keysize determination from Kconfig files

Success Failures Total Runtime
10105 0 10105 14m:19s

Artifacts

@mguetschow mguetschow added this pull request to the merge queue May 16, 2024
@mguetschow mguetschow removed this pull request from the merge queue due to a manual request May 16, 2024
@mguetschow mguetschow added this pull request to the merge queue May 16, 2024
Merged via the queue into RIOT-OS:master with commit e9f290c May 16, 2024
28 checks passed
@mguetschow mguetschow deleted the psa-crypto-keysize branch May 17, 2024 08:24
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants