Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers: don't call i2c_init() #20675

Merged
merged 1 commit into from
May 16, 2024
Merged

drivers: don't call i2c_init() #20675

merged 1 commit into from
May 16, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

This is already called by periph_init()

Testing procedure

Issues/PRs references

found in #20668 (comment)

@benpicco
drivers: don't call i2c_init()
85b2dec 
This is already called by periph_init()
@github-actions github-actions bot added the Area: drivers Area: Device drivers label May 16, 2024
@benpicco benpicco added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed Area: drivers Area: Device drivers labels May 16, 2024
mguetschow
mguetschow approved these changes May 16, 2024
View reviewed changes
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for fixing!

@benpicco benpicco enabled auto-merge May 16, 2024 13:23
@riot-ci
Copy link

riot-ci commented May 16, 2024

Murdock results

✔️ PASSED

85b2dec drivers: don't call i2c_init()

Success Failures Total Runtime
10104 0 10105 14m:22s

Artifacts

@benpicco benpicco added this pull request to the merge queue May 16, 2024
Merged via the queue into RIOT-OS:master with commit 719663f May 16, 2024
31 checks passed
@benpicco benpicco deleted the drivers-i2c_init branch May 16, 2024 22:36
@mguetschow mguetschow added this to the Release 2024.07 milestone Jun 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mguetschow mguetschow mguetschow approved these changes

@maribu maribu Awaiting requested review from maribu

Assignees
No one assigned
Labels
Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
Release 2024.07
Development

Successfully merging this pull request may close these issues.
3 participants
@benpicco @riot-ci @mguetschow