drivers/w5500: fix W5500 link up/down events in interrupt mode #20728
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LP-HAW
requested review from
leandrolanzieri,
jia200x,
MrKevinWeiss,
aabadie and
MichelRottleuthner
as code owners
github-actions
bot
added
Area: tests
benpicco
added
the
Type: bug
benpicco
reviewed
Jun 5, 2024
LP-HAW
force-pushed
the
fix-w5500-link-state
branch
from
8ffac33
to
5e54851
Compare
benpicco
reviewed
Jun 5, 2024
LP-HAW
force-pushed
the
fix-w5500-link-state
branch
from
5e54851
to
8ab2c79
Compare
benpicco
added
the
CI: ready for build
benpicco
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This PR fixes link up/down events in the W5500 driver in interrupt mode. Apparently the W5500 in MACRAW mode does not generate an interrupt when the link goes up or down. Work around this by polling even in interrupt mode.
I noticed that the W5500 interface would not configure an address after a reset until it received a packet. Also, addresses assigned to the interface are not removed and reconfigured when the network cable is unplugged and plugged back in.
Testing procedure
Build RIOT with W5500 in interrupt mode, e.g.
USEMODULE="w5500 auto_init_w5500" CFLAGS="-DW5500_PARAM_INT=GPIO_PIN\(0,0\)" make -C examples/gcoap all flash termUnplug network cable
Run
ifconfigWithout this PR:
The interface is down but still assigned an IPv6 address.
With this PR:
The interface has no address assigned to it.
Issues/PRs references
None