Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

event_periodic_callback: add event_periodic_callback_oneshot() #20861

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

benpicco
Copy link
Contributor

Contribution description

Often there is a need to execute an event once after a delay.
This adds a convenience helper function for it.

Testing procedure

A test for the new function has been added to tests/sys/event_periodic_callback

Issues/PRs references

@github-actions github-actions bot added Area: tests Area: tests and testing framework Area: sys Area: System labels Sep 11, 2024
@benpicco benpicco force-pushed the event_periodic_callback_oneshot branch from 3f294a7 to bef6232 Compare September 11, 2024 13:15
@benpicco benpicco added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Sep 11, 2024
@riot-ci
Copy link

riot-ci commented Sep 11, 2024

Murdock results

✔️ PASSED

bef6232 tests/event_periodic_callback: add test for oneshot event

Success Failures Total Runtime
10196 0 10197 15m:10s

Artifacts

@mguetschow
Copy link
Contributor

I'm not too familiar with the details of the different event queue APIs, but the naming event_periodic_callback_onshot() sounds confusing. I would expect to be an event either periodic or oneshot :P

@kfessel
Copy link
Contributor

kfessel commented Sep 25, 2024

I'm not too familiar with the details of the different event queue APIs, but the naming event_periodic_callback_onshot() sounds confusing. I would expect to be an event either periodic or oneshot :P

I would not expect a periodic event to count but somehow it does looks a bit going a egg-laying-wool-milk-pig attempt to events which are not events but tasks that are parsed by workers named event threads

I think the naming of and the actual implementation is quiet fitting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: sys Area: System Area: tests Area: tests and testing framework CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants