Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

drivers/netdev: revise return values of .confirm_send() #20995

Merged
merged 2 commits into from
Nov 16, 2024
Merged

drivers/netdev: revise return values of .confirm_send() #20995

merged 2 commits into from
Nov 16, 2024

Conversation

benpicco
Copy link
Contributor

Contribution description

  • Missing l2 ACK should be EHOSTUNREACH
  • Collision should be EBUSY
  • stm32 eth already uses ENETDOWN for no link / sleep, document that

Testing procedure

Issues/PRs references

@github-actions github-actions bot added Platform: ARM Platform: This PR/issue effects ARM-based platforms Area: drivers Area: Device drivers Area: cpu Area: CPU/MCU ports labels Nov 15, 2024
@benpicco benpicco requested a review from maribu November 15, 2024 13:20
@benpicco benpicco changed the title drivers/netdev: revise return values of .confirm_send() drivers/netdev: revise return values of .confirm_send() Nov 15, 2024
@benpicco benpicco added Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care. CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 15, 2024
@riot-ci
Copy link

riot-ci commented Nov 15, 2024

Murdock results

✔️ PASSED

08fc52b cpu/sam0_common: eth: collision should return -EBUSY

Success Failures Total Runtime
10250 0 10251 15m:10s

Artifacts

@maribu maribu added this pull request to the merge queue Nov 15, 2024
@maribu maribu removed this pull request from the merge queue due to the queue being cleared Nov 15, 2024
@maribu maribu added this pull request to the merge queue Nov 15, 2024
@maribu maribu removed this pull request from the merge queue due to the queue being cleared Nov 15, 2024
@maribu maribu added this pull request to the merge queue Nov 15, 2024
Merged via the queue into RIOT-OS:master with commit dedc8f9 Nov 16, 2024
29 checks passed
@benpicco benpicco deleted the confirm_send-retval branch November 16, 2024 15:40
@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@dylad dylad dylad approved these changes

@keestux keestux Awaiting requested review from keestux keestux is a code owner

Assignees
No one assigned
Labels
Area: cpu Area: CPU/MCU ports Area: drivers Area: Device drivers CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Process: API change Integration Process: PR contains or issue proposes an API change. Should be handled with care.
Projects
None yet
Milestone
Release 2025.01
Development

Successfully merging this pull request may close these issues.
5 participants
@benpicco @riot-ci @maribu @dylad @MrKevinWeiss