Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

boards/wemos-zero: fix Arduio I/O Map #21004

Merged

Conversation

maribu
Copy link
Member

@maribu maribu commented Nov 18, 2024

Contribution description

Two pins were incorrectly mapped: D2 and D4 are swapped compared to the official Arduino Zero. In addition the is slightly extended.

Testing procedure

Pinout for Arduino Zero

Official Pinout

Pinout for Clones

Clone Pinout

Issues/PRs references

None

@maribu maribu added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Nov 18, 2024
@github-actions github-actions bot added Area: doc Area: Documentation Area: boards Area: Board ports labels Nov 18, 2024
@riot-ci
Copy link

riot-ci commented Nov 19, 2024

Murdock results

✔️ PASSED

fd233fe boards/wemos-zero: add note for identification

Success Failures Total Runtime
10248 0 10249 18m:03s

Artifacts

Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing! Some nits below.

boards/wemos-zero/doc.txt Outdated Show resolved Hide resolved
boards/wemos-zero/doc.txt Outdated Show resolved Hide resolved
@maribu maribu force-pushed the boards/common/arduino-zero/arduino-iomap branch 3 times, most recently from 693eda4 to 0744712 Compare November 19, 2024 12:10
maribu and others added 2 commits November 19, 2024 13:12
Two pins were incorrectly mapped because D2 and D4 are swapped on the
WeMos zero compared to the Arduino Zero. This takes the difference
into account.
The variant with HW-819 is easier to buy these days and identical to
the original wemos-zero variant including the swapped D2/D4 pins.

Co-authored-by: mguetschow <mikolai.guetschow@tu-dresden.de>
@maribu maribu force-pushed the boards/common/arduino-zero/arduino-iomap branch from 0744712 to fd233fe Compare November 19, 2024 12:12
Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks again!

@mguetschow mguetschow enabled auto-merge November 19, 2024 12:30
@mguetschow mguetschow added this pull request to the merge queue Nov 19, 2024
Merged via the queue into RIOT-OS:master with commit 89b5169 Nov 19, 2024
26 checks passed
@maribu maribu deleted the boards/common/arduino-zero/arduino-iomap branch November 19, 2024 19:12
@maribu
Copy link
Member Author

maribu commented Nov 19, 2024

Thx for the review :)

@MrKevinWeiss MrKevinWeiss added this to the Release 2025.01 milestone Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: boards Area: Board ports Area: doc Area: Documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants