-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards/wemos-zero: fix Arduio I/O Map #21004
Merged
mguetschow
merged 2 commits into
RIOT-OS:master
from
maribu:boards/common/arduino-zero/arduino-iomap
Nov 19, 2024
Merged
boards/wemos-zero: fix Arduio I/O Map #21004
mguetschow
merged 2 commits into
RIOT-OS:master
from
maribu:boards/common/arduino-zero/arduino-iomap
Nov 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mguetschow
requested changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing! Some nits below.
693eda4
to
0744712
Compare
Two pins were incorrectly mapped because D2 and D4 are swapped on the WeMos zero compared to the Arduino Zero. This takes the difference into account.
The variant with HW-819 is easier to buy these days and identical to the original wemos-zero variant including the swapped D2/D4 pins. Co-authored-by: mguetschow <mikolai.guetschow@tu-dresden.de>
0744712
to
fd233fe
Compare
mguetschow
approved these changes
Nov 19, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks again!
Thx for the review :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: boards
Area: Board ports
Area: doc
Area: Documentation
CI: ready for build
If set, CI server will compile all applications for all available boards for the labeled PR
Type: bug
The issue reports a bug / The PR fixes a bug (including spelling errors)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
Two pins were incorrectly mapped: D2 and D4 are swapped compared to the official Arduino Zero. In addition the is slightly extended.
Testing procedure
Pinout for Arduino Zero
Pinout for Clones
Issues/PRs references
None