Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: Use RIOT maintained cosy #21070

Merged
merged 1 commit into from
Jan 31, 2025

Conversation

chrysn
Copy link
Member

@chrysn chrysn commented Dec 10, 2024

Contribution description

make cosy is an easy and well-established way to see how cosily the full built code fits in the microcontroller.

Hauke has apparently ceased maintaining the upstream respository, and we have forked it into the RIOT-OS group on GitHub to keep maintaining it there. (It also fits: The tool may be adjusted for other systems, but its code has a few inherent assumptions about RIOT baked in that makes that nontrivial).

This PR

  • Places our fork as the new upstream,
  • drops all patches (because they were now merged), and
  • updates to the latest cosy.

Testing procedure

  • Pick any example (eg. hello-world)
  • make cosy BOARD=microbit-v2 (or any board you like)
  • Look at the web page indicated by the output.

Issues/PRs references

The patches dropped were merged in RIOT-OS/cosy#4 and RIOT-OS/cosy#7; other patches have been merged in since.

This PR is not ready for review yet because I'd like to also get RIOT-OS/cosy#6 in, and maybe also RIOT-OS/cosy#2; in fact, the commit hash currently in here points to a dangling commit pushed to test merging PR6 in it.

@chrysn chrysn added Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation Area: tools Area: Supplementary tools labels Dec 10, 2024
@chrysn
Copy link
Member Author

chrysn commented Dec 10, 2024

This PR may warrant a statement that "the RIOT project has taken in development of the cosy tool under its umbrella", but we have no flag "Releas notes: noteworthy".

@mguetschow
Copy link
Contributor

@chrysn with all PRs in at https://github.com/RIOT-OS/cosy, would you mind bumping the pkg commit to current master?

@chrysn chrysn marked this pull request as ready for review January 31, 2025 13:13
@chrysn chrysn added the CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR label Jan 31, 2025
@riot-ci
Copy link

riot-ci commented Jan 31, 2025

Murdock results

✔️ PASSED

4201f4f tools: Use RIOT maintained cosy

Success Failures Total Runtime
1 0 1 01m:11s

Artifacts

@chrysn
Copy link
Member Author

chrysn commented Jan 31, 2025

Updated but can't test it right now (too deep in other parts); could you run a final test?

Copy link
Contributor

@mguetschow mguetschow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, works great! 🎉

@mguetschow mguetschow enabled auto-merge January 31, 2025 13:23
@mguetschow mguetschow added this pull request to the merge queue Jan 31, 2025
Merged via the queue into RIOT-OS:master with commit 775f596 Jan 31, 2025
27 checks passed
@chrysn chrysn deleted the own-cosy branch February 20, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: tools Area: Supplementary tools CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants