Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sys/net/gnrc/netif: pktqueue: don't clash with GNRC_NETIF_FLAGS_6LO_HC #21217

Merged
merged 1 commit into from
Feb 14, 2025
Merged

sys/net/gnrc/netif: pktqueue: don't clash with GNRC_NETIF_FLAGS_6LO_HC #21217

merged 1 commit into from
Feb 14, 2025

Conversation

benpicco
Copy link
Contributor

@benpicco benpicco commented Feb 14, 2025 •
edited
Loading

Contribution description

Both GNRC_NETIF_FLAGS_6LO_HC and GNRC_NETIF_FLAGS_TX_FROM_PKTQUEUE were using the same flag.
This meant that IPHC was always unset after a queued send (because GNRC_NETIF_FLAGS_TX_FROM_PKTQUEUE gets set/unset then).

Testing procedure

Issues/PRs references

@benpicco benpicco changed the title sys/net/gnrc/netif: pktqueue: don't clash with GNRC_NETIF_FLAGS_6LO_HC sys/net/gnrc/netif: pktqueue: don't clash with GNRC_NETIF_FLAGS_6LO_HC Feb 14, 2025
@github-actions github-actions bot added Area: network Area: Networking Area: sys Area: System labels Feb 14, 2025
@benpicco benpicco added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) labels Feb 14, 2025
@benpicco benpicco requested review from maribu and miri64 February 14, 2025 15:51
@benpicco benpicco added the Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer label Feb 14, 2025
@maribu maribu enabled auto-merge February 14, 2025 16:14
@riot-ci
Copy link

riot-ci commented Feb 14, 2025 •
edited
Loading

Murdock results

✔️ PASSED

82e8920 sys/net/gnrc/netif: pktqueue: don't clash with GNRC_NETIF_FLAGS_6LO_HC

Success Failures Total Runtime
10271 0 10271 11m:45s

Artifacts

@maribu maribu added this pull request to the merge queue Feb 14, 2025
@miri64
Copy link
Member

miri64 commented Feb 14, 2025

Please take a look at the applications actually build. This is the first PR run on Murdock after #21213 got merged but the examples e.g. were not included in https://ci.riot-os.org/details/a363dc571f704f7db37da850a1f6e8ed.

@maribu maribu removed this pull request from the merge queue due to a manual request Feb 14, 2025
@maribu maribu added CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR and removed CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Feb 14, 2025
@maribu maribu enabled auto-merge February 14, 2025 16:31
@maribu maribu added this pull request to the merge queue Feb 14, 2025
Merged via the queue into RIOT-OS:master with commit 8947e0c Feb 14, 2025
31 checks passed
@benpicco benpicco deleted the GNRC_NETIF_FLAGS_TX_FROM_PKTQUEUE-fix branch February 15, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maribu maribu maribu approved these changes

@miri64 miri64 Awaiting requested review from miri64

@MrKevinWeiss MrKevinWeiss Awaiting requested review from MrKevinWeiss

Assignees
No one assigned
Labels
Area: network Area: Networking Area: sys Area: System CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@benpicco @riot-ci @miri64 @maribu