build-system: do not create empty folders named 1

[maribu]

Contribution description

Running BUILD_IN_DOCKER=1 in an application folder outside of RIOT created empty 1 folders by adding

-v '<path/to/external/app>/1:/data/riotbuild/0:delegated' -e 'BUILD_IN_DOCKER=/data/riotbuild/0'

to the docker command line.

This changes the invocation to add just -e 'BUILD_IN_DOCKER=0' instead.

Testing procedure

Running make BUILD_IN_DOCKER=1 should not leave turds in the file system anymore, even when doing so in an external app dir.

Issues/PRs references

Bug introduced in #20638.

[riot-ci]

Murdock results

✔️ PASSED

193aa54 build-system: do not create empty folders named 1

Success	Failures	Total	Runtime
10931	0	10932	18m:12s

Artifacts

• Documentation preview

[crasbe]

I added $(info $(call docker_volume_and_env,BUILD_IN_DOCKER,,0) to line 308 to see what was previously set in the environment even on a normal call:

buechse@skyleaf:~/RIOTstuff/riot-vanillaice/RIOT$ BUILD_IN_DOCKER=1 make -C tests/sys/shell
make: Entering directory '/home/buechse/RIOTstuff/riot-vanillaice/RIOT/tests/sys/shell'
using BOARD="native64" as "native" on a 64-bit system
-e 'BUILD_IN_DOCKER=/data/riotbuild/riotbase/tests/sys/shell/1'
Launching build container using image "docker.io/riot/riotbuild@sha256:08fa7da2c702ac4db7cf57c23fc46c1971f3bffc4a6eff129793f853ec808736".
docker run --rm --tty --user $(id -u) --platform linux/amd64 -v '/usr/share/zoneinfo/Europe/Berlin:/etc/localtime:ro' -v '/home/buechse/RIOTstuff/riot-vanillaice/RIOT:/data/riotbuild/riotbase:delegated' -v '/home/buechse/.cargo/registry:/data/riotbuild/.cargo/registry:delegated' -v '/home/buechse/.cargo/git:/data/riotbuild/.cargo/git:delegated' -e 'RIOTBASE=/data/riotbuild/riotbase' -e 'CCACHE_BASEDIR=/data/riotbuild/riotbase' -e 'BUILD_DIR=/data/riotbuild/riotbase/build' -e 'BUILD_IN_DOCKER=0' -e 'RIOTPROJECT=/data/riotbuild/riotbase' -e 'RIOTCPU=/data/riotbuild/riotbase/cpu' -e 'RIOTBOARD=/data/riotbuild/riotbase/boards' -e 'RIOTMAKE=/data/riotbuild/riotbase/makefiles'       -e 'DISABLE_MODULE=' -e 'DEFAULT_MODULE=test_utils_print_stack_usage' -e 'FEATURES_REQUIRED=' -e 'FEATURES_BLACKLIST=' -e 'FEATURES_OPTIONAL=' -e 'USEMODULE=app_metadata ps shell_builtin_cmd_help_json shell_cmds_default ztimer_msec' -e 'USEPKG='  -w '/data/riotbuild/riotbase/tests/sys/shell/' 'docker.io/riot/riotbuild@sha256:08fa7da2c702ac4db7cf57c23fc46c1971f3bffc4a6eff129793f853ec808736' make
using BOARD="native64" as "native" on a 64-bit system
-e 'BUILD_IN_DOCKER=/data/riotbuild/riotbase/tests/sys/shell/0'
Building application "tests_shell" for "native64" with CPU "native".

So essentially this (outside the container, inside the container):

-e 'BUILD_IN_DOCKER=/data/riotbuild/riotbase/tests/sys/shell/1'
-e 'BUILD_IN_DOCKER=/data/riotbuild/riotbase/tests/sys/shell/0'

So yeah, fascinating that it worked at all.

[maribu]

Thx ❤️