oonf_api: use RIOT_VERSION as platform identifier for RIOT

[benpicco]

Some third-party code my come with #ifdefs to conditionally compile some parts for RIOT, while maintaining the possibility to compile for Linux, Windows, etc.

This makes oonf_api check if RIOT_VERSION is defined for RIOT specific codepaths.

fixes #2772

[Kijewski]

Strong dislike. We have RIOT_BOARD, RIOT_CPU, RIOT_MCU and RIOT_VERSION. I'd prefer #ifdef RIOT_BOARD.

[OlegHahm]

Independent from the question if we need this (see #2772), I would argue that a platform identifying macro is something completely else than the RIOT internal defines specifying the board or CPU.

[kaspar030]

Strong dislike. We have RIOT_BOARD, RIOT_CPU, RIOT_MCU and RIOT_VERSION. I'd prefer #ifdef RIOT_BOARD.

I tend to agree here, those defines should be enough.

I would argue that a platform identifying macro is something completely else than the RIOT internal defines specifying the board or CPU.

That's why I'd go for #ifdef RIOT_VERSION.

[benpicco]

That's why I'd go for #ifdef RIOT_VERSION.

Ok.

[haukepetersen]

Agree with @Kijewski and @kaspar030, RIOT_VERSION just do just fine.

[OlegHahm]

Sounds good to me. ACK if Travis is fine.

[LudwigKnuepfer]

Please change the commit message to use the module as a prefix. (Compare git log)

[OlegHahm]

kicked Travis

[OlegHahm]

For the record: Travis is green - if you just change the commit message, we're ready to go.

[benpicco]

Am Wed, 15 Apr 2015 22:52:58 -0700
schrieb Ludwig Ortmann notifications@github.com:

Please change the commit message to use the module as a prefix.

done

[OlegHahm]

and go