-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
posix: redo socket API to use conn #3646
Conversation
|
res = -1; | ||
} | ||
break; | ||
#endif |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From miri64@902d305#commitcomment-12756195:
how about:
case AF_INET: case AF_INET6: s->domain = domain; s->type = type; if ((s->protocol = _choose_ipproto(type, protocol)) < 0) { res = -1; } break;
That's different from the current code in that this code segment will be entered even if the associated connection modules are not there. But I can put the EAFNOSUPPORT
check for them to the top.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ahh domain
may be AF_INET
or AF_INET6
even if CONN_IPV4 || CONN_IPV6
are not available, the forget my noise :)
60518b4
to
fb6c95f
Compare
fb6c95f
to
82fd442
Compare
Rebased to current master |
82fd442
to
5f15c4d
Compare
Rebased to current master and dependencies. |
@BytesGalore what did you mean with that? |
a6d9313
to
06185b5
Compare
Rebased to current dependencies |
nvm. @OlegHahm pointed me that I commented on commits from this PR and not on the PR, so that was something I didn't wanted :) |
bfec82b
to
e83244b
Compare
Rebased to current master and dependencies. |
bfec82b
to
647a0af
Compare
And now for real. |
f15f9c3
to
e95cde4
Compare
Maybe the READ ME could be more complete -- especially for programmers expected above a POSIX socket in this context. E.g. in EXAMPLE OUTPUT, indicate that |
Since when? If you want to use a different tap interface apart from |
oops my bad. Ignore ;) |
Update README. |
Looks good. ACK. |
15f1ce2
to
b48f3d4
Compare
Squashed |
f88e409
to
ded545d
Compare
Fixed issues with |
ded545d
to
d94c997
Compare
Another (bug) one bites the dust. This time it was Arduino with its pesky 16-bit |
d94c997
to
0d25815
Compare
(hopefully) last one. |
0d25815
to
c36f9e0
Compare
Let's give it one last round for today, shall we (blacklisted |
posix: redo socket API to use conn
The last comment sounded like a question... |
It was a rhetorical question intended to mask my frustration about the last minutes of this PR. |
Depends on
#3611(merged),#3612(merged),#3615(merged) and#3660(merged).