gnrc_rpl: fix dependencies

[miri64]

Follow-up to #3050.

The dependency conditional for RPL was at the very end of Makefile.dep, giving depending modules no chance to pull in their dependencies (rpl just lists them as dependencies too).

Also it pulled in the deprecated module net_help, though it did not use any of it's functions (it just included inet_pton.h for AF_INET6).

[OlegHahm]

Also it pulled in the deprecated module net_help, though it did not use any of it's functions (it just included inet_pton.h for AF_INET6).

Hence, the include should not be removed, right?

/home/oleg/git/RIOT/sys/net/routing/ng_rpl/ng_rpl_dodag.c: In function 'ng_rpl_parent_add_by_addr'
/home/oleg/git/RIOT/sys/net/routing/ng_rpl/ng_rpl_dodag.c:245:67: error: 'AF_INET6' undeclared (first use in this function)
             if (fib_add_entry(if_id, def.u8, sizeof(ipv6_addr_t), AF_INET6, dodag->parents->addr.u8,
                                                                   ^
/home/oleg/git/RIOT/sys/net/routing/ng_rpl/ng_rpl_dodag.c:245:67: note: each undeclared identifier is reported only once for each function it appears in
/home/oleg/git/RIOT/sys/net/routing/ng_rpl/ng_rpl_dodag.c: In function 'ng_rpl_parent_update'
/home/oleg/git/RIOT/sys/net/routing/ng_rpl/ng_rpl_dodag.c:327:67: error: 'AF_INET6' undeclared (first use in this function)
                 fib_add_entry(if_id, def.u8, sizeof(ipv6_addr_t), AF_INET6,
                                                                   ^
/home/oleg/git/RIOT/sys/net/routing/ng_rpl/ng_rpl_dodag.c: In function 'ng_rpl_find_preferred_parent'
/home/oleg/git/RIOT/sys/net/routing/ng_rpl/ng_rpl_dodag.c:388:59: error: 'AF_INET6' undeclared (first use in this function)
         fib_add_entry(if_id, def.u8, sizeof(ipv6_addr_t), AF_INET6, dodag->parents->addr.u8,
    ```

[miri64]

Hence, the include should not be removed, right?
I thought I did -.-

[miri64]

Addressed.

[cgundogan]

looks sane. Could you please also remove the USEMODULE += timex as it gets pulled in by vtimer?

[cgundogan]

You could also remove the vtimer entry, because the fib pulls it in

[miri64]

You could also remove the vtimer entry, because the fib pulls it in

Isn't RPL using vtimers itself too?

[cgundogan]

Yes it is, but I assumed the dependency gets pulled in transitively?

[OlegHahm]

Yes it is, but I assumed the dependency gets pulled in transitively?

In general they are, but I would also strongly vote for making them explicit. fib may drop the need for timers in a theoretical future version.

[cgundogan]

makes sense. never mind then, forget what I wrote before

[miri64]

Removed the timex dependency.

[cgundogan]

I am fine with the changes. ACK. Fixup please

[miri64]

Squashed.

[cgundogan]

please rememove the extra pe in depependencies (commit msg)

[miri64]

Done.