-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
drivers/periph/uart: remodeled UART interface #4114
Conversation
#4115 gives an example, how the changed interface can be utilized for improved UART driver implementations... |
@gebart, @jfischer-phytec-iot, @kaspar030: are you guys ok with these changes in the UART interface? |
a019504
to
4553c35
Compare
rebased |
After discussions in #3265, do we consent on this approach? Or are their any objections? @daniel-k @gebart @kaspar030 @jfischer-phytec-iot @OlegHahm @sgso @PeterKietzmann |
I like the simplified API. You have my approval. |
I also like the approach on the first sight. I just started to look at it again and try it with some boards |
@PeterKietzmann Great, could you note down the boards you tested here? |
Of course... |
I placed a list of boards in the PR description above and checked some boards that I currently have available (marked them there). Until now I didn't face any problems |
damn, I actually thought we could go around testing every board, as this takes forever again... I mean this PR doesn't change anything logical in the uart drivers, so a good code review and testing of some selected boards should suffice I was hoping... |
Since this does not change the logic (much), it should be enough to do a quick manual code review, and some spot checks by running tests/periph_uart on various boards along with testing the users on any platform (stdio, gnrc_slip, drivers/xbee). |
I don't want to be responsible for this PR, so I leave the decision up to you ;-) ! I agree with your arguments, even if testing seems to be the "safer" way in general. With my above stated list I did |
@PeterKietzmann: yes, give an ack :-) |
ACK for the part that I tested (described above). |
thx! @gebart: did you get to test this on the mulle board? |
Travis disagrees in some points :-( |
I see, will fix tomorrow. |
fixed those Travis issues: by added |
My ACK holds for the parts that I tested. But I don't dare to hit the button as this doesn't cover the whole PR. Anyone else? |
yes, with pleasure :-) |
drivers/periph/uart: remodeled UART interface
Nice one! |
supersedes #3265
After many iterations #3265 became un-managable, so I decided for a clean approach using the latest consensus. The UART interface is now significantly simplified, only one write function remains. The concepts summarized:
All existing CPUs are adapted to the interface changes -> dropping ~1500 lines of code :-)
I did however just adapt the UART drivers for the introduced interface changes, I did not optimize any of the drivers -> this can/has to be done CPU by CPU in follow up PRs, as this is also easier to review...
Tested for:
UART_0
UART_0
UART_0
andUART_1
UART_0