Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cpu/saml21: Conditionally define LITTLE_ENDIAN #5601

Merged
merged 1 commit into from
Jul 5, 2016
Merged

cpu/saml21: Conditionally define LITTLE_ENDIAN #5601

merged 1 commit into from
Jul 5, 2016

Conversation

jnohlgard
Copy link
Member

Caused problems with redefined macros when building with a recent newlib.

Follow up to #5600

cpu: Conditionally define LITTLE_ENDIAN
7275f98 
Caused problems with redefined macros when building with a recent newlib
@jnohlgard jnohlgard added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Platform: ARM Platform: This PR/issue effects ARM-based platforms Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Jul 5, 2016
@jnohlgard jnohlgard added this to the Release 2016.07 milestone Jul 5, 2016
This was referenced Jul 5, 2016
Merged
Merged
@miri64
Copy link
Member

miri64 commented Jul 5, 2016

I'm alright with this change. ACK and go? (there are two reviewers assigned so do you want two reviews?)

@jnohlgard
Copy link
Member Author

I added you two since @OlegHahm fixed the samd21 and you were having trouble with the new GCC-6 toolchain. Let's just get this merged.

@jnohlgard jnohlgard merged commit 60643af into RIOT-OS:master Jul 5, 2016
@jnohlgard jnohlgard deleted the pr/saml21-little-endian branch July 5, 2016 21:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@miri64 miri64

@OlegHahm OlegHahm

Labels
CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jnohlgard @miri64 @OlegHahm