sock_tcp: Add missing function and doc #5923
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miri64
added
Area: network
miri64
force-pushed
the
sock/api/add-missing-func+doc
branch
2 times, most recently
from
9456d5a
to
94b3031
Compare
This was referenced Oct 11, 2016
|
Rebased to master and adapted for #5929 (also added timeout to |
miri64
force-pushed
the
sock/api/add-missing-func+doc
branch
from
94b3031
to
fc67664
Compare
miri64
commented
Oct 12, 2016
| * | ||
| * @note Function may block. | ||
| * | ||
| * @return The number of bytes read on success. | ||
| * @return 0, if no read data is available, but everything is in order. | ||
| * @return -EADDRNOTAVAIL, if local of @p sock is not given. |
There was a problem hiding this comment.
Anyone remember why we introduced that? Since a sock can properly only be initialized via sock_tcp_connect() and sock_tcp_listen() they only can't have a local end point, if they are not connected (i.e. not initialized), so this result would be the same case as -ENOTCONN. @kaspar030 @brummer-simon?
aabadie
reviewed
Oct 17, 2016
| * puts("Error creating listening queue"); | ||
| * return 1; | ||
| * } | ||
| * puts("Accepting on port 12345"); |
There was a problem hiding this comment.
well in l. 49 below it starts accepting...
aabadie
reviewed
Oct 17, 2016
| * } | ||
| * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ | ||
| * | ||
| * In the case of we somehow manage to break the indefinite accepting loop we |
There was a problem hiding this comment.
UDP and IP doc say indefinite in a similar case.
There was a problem hiding this comment.
Ah sorry, thought it was a different line ^^"
aabadie
requested changes
Oct 17, 2016
|
Addressed comments. |
aabadie
approved these changes
Oct 17, 2016
miri64
force-pushed
the
sock/api/add-missing-func+doc
branch
from
aecf754
to
6e2f1c5
Compare
|
Squashed |
miri64
added
the
CI: ready for build
|
And Go ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides detailed examples for
sock_tcpand fixes for the documentation. Also, there wasn't any function to get the local end point of a listening queue yet, but this adds it.