Skip to content

cpu/sam0: move sam0.h to vendor header tree #7038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 11, 2017
Merged

cpu/sam0: move sam0.h to vendor header tree #7038

merged 1 commit into from
May 11, 2017

Conversation

@haukepetersen
Copy link
Contributor

@haukepetersen haukepetersen commented May 11, 2017

the sam0.h is basically a vendor header and it's single purpose is to pull in the correct vendor headers. For this reason, it should not be included by our static tests and it makes herewith sense to move it into the vendor/ tree.

@haukepetersen haukepetersen added Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels May 11, 2017
@haukepetersen haukepetersen added this to the Release 2017.07 milestone May 11, 2017
@haukepetersen haukepetersen mentioned this pull request May 11, 2017
Merged
@kaspar030
Copy link
Contributor

kaspar030 commented May 11, 2017

Fine with me.

kaspar030
kaspar030 approved these changes May 11, 2017
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64 miri64 merged commit 044ac55 into RIOT-OS:master May 11, 2017
@haukepetersen haukepetersen deleted the opt_sam0_sam0htovendor branch May 12, 2017 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

@aabadie aabadie

@kaspar030 kaspar030

Labels

CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Platform: ARM Platform: This PR/issue effects ARM-based platforms Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation

Projects

None yet

Milestone

Release 2017.07

Development

Successfully merging this pull request may close these issues.

4 participants

@haukepetersen @kaspar030 @miri64 @aabadie