Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

core/thread_flags: Remove unused THREAD_FLAG_MUTEX_UNLOCKED #7717

Merged
merged 1 commit into from
Oct 13, 2017
Merged

core/thread_flags: Remove unused THREAD_FLAG_MUTEX_UNLOCKED #7717

merged 1 commit into from
Oct 13, 2017

Conversation

jnohlgard
Copy link
Member

and improve docs for THREAD_FLAG_TIMEOUT

Fixes #7543

@jnohlgard jnohlgard added Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation Area: core Area: RIOT kernel. Handle PRs marked with this with care! Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Oct 11, 2017
@jnohlgard jnohlgard added this to the Release 2017.10 milestone Oct 11, 2017
@jnohlgard jnohlgard mentioned this pull request Oct 11, 2017
Closed
kaspar030
kaspar030 reviewed Oct 11, 2017
View reviewed changes
core/include/thread_flags.h Outdated
#define THREAD_FLAG_MUTEX_UNLOCKED (0x1<<14)
#define THREAD_FLAG_TIMEOUT (0x1<<13)
/**
* @brief Thread flag which is set by xtimer_set_timeout_flag when the timer expires
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(minor, feel free to change)

The other flag has "Set when ..." as brief. IMO "Set by @ref xtimer_set_timeout_flag() when the timer expires" would fit better here, for more consistent look in the generated doxygen.

kaspar030
kaspar030 approved these changes Oct 11, 2017
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK. feel free to squash in the doxygen comment.

core/thread_flags: Remove unused THREAD_FLAG_MUTEX_UNLOCKED
317b013 
and improve docs for THREAD_FLAG_TIMEOUT
@jnohlgard jnohlgard force-pushed the pr/thread-flags-rm-mutex-unlock branch from 8c63837 to 317b013 Compare October 12, 2017 12:31
@jnohlgard
Copy link
Member Author

amended Doxygen change

@jnohlgard
Copy link
Member Author

Murdock is happy -> go

@jnohlgard jnohlgard merged commit 1fec7e6 into RIOT-OS:master Oct 13, 2017
@jnohlgard jnohlgard deleted the pr/thread-flags-rm-mutex-unlock branch October 13, 2017 07:14
@chrysn chrysn mentioned this pull request Jan 5, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees

@kaspar030 kaspar030

Labels
Area: core Area: RIOT kernel. Handle PRs marked with this with care! CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Impact: minor The PR is small in size and might only require a quick look of a knowledgeable reviewer Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2017.10
Development

Successfully merging this pull request may close these issues.
2 participants
@jnohlgard @kaspar030