Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make: couple include path and -I #803

Merged
merged 1 commit into from
Feb 27, 2014

Conversation

LudwigKnuepfer
Copy link
Member

This is necessary if includes have to be filtered, such as in native
to throw out RIOTs posix includes which interfere with system
includes.

This is part of a fix for #793

This is necessary if includes have to be filtered, such as in native
to throw out RIOTs posix includes which interfere with system
includes.
@OlegHahm
Copy link
Member

Looks problem-free, but what exactly causes the problem with the white-spaces?

@LudwigKnuepfer
Copy link
Member Author

This construct $(filter-out -I$(RIOTBASE)/sys/posix% , $(INCLUDES)) only works if there is no space between -I and the path in $(INCLUDES). Otherwise -I is treated as one list element and the path is treated as another list element.

@LudwigKnuepfer
Copy link
Member Author

(Even if it was possible to sensibly remove all variants of paths from the $(INCLUDES), it would not be trivial to remove the remaining single -I occurences..)

@OlegHahm
Copy link
Member

Ah, I see. ACK

LudwigKnuepfer added a commit that referenced this pull request Feb 27, 2014
@LudwigKnuepfer LudwigKnuepfer merged commit a577661 into RIOT-OS:master Feb 27, 2014
@LudwigKnuepfer LudwigKnuepfer deleted the couple_include_defs branch February 27, 2014 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Type: enhancement The issue suggests enhanceable parts / The PR enhances parts of the codebase / documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants