boards: efm32: adapt pr feedback for other boards #8794
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
basilfx
added
Type: enhancement
basilfx
force-pushed
the
feature/efm32_fix_style
branch
2 times, most recently
from
9d8b826 to
2a0ba35
Compare
aabadie
approved these changes
Mar 16, 2018
|
For what its worth, this is the proof that it still runs after 4ff507a 🤓 SLTB001a: SLSTK3401a: |
|
Minor: there's a typo in 4555570 commit message (tradfir instead of tradfri). |
basilfx
force-pushed
the
feature/efm32_fix_style
branch
from
2a0ba35 to
f75d426
Compare
|
Fixed that one. |
aabadie
reviewed
Mar 16, 2018
boards/sltb001a/board.c
Outdated
| #include "periph/gpio.h" | ||
| #include "pic.h" |
There was a problem hiding this comment.
Maybe this include could be protected with a #ifdef MODULE_SILABS_PIC ?
There was a problem hiding this comment.
I can add that, but it compiles fine without (if I remove silabs_pic from the USEMODULES).
Let me know what you prefer.
There was a problem hiding this comment.
On second thought: I'll add it. That's more similar to how we also include optional peripherals.
Will do the same for AEM.
|
Added the conditional includes, and tested that it still works. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
During the review of #8630 some comments were raised that have slipped through. This PR adapts these comments for the:
ikea-tradfrisltb001astk3600stk3700Issues/PRs references
#7929
#8047
#8585
#8520