Skip to content

Conversation

@miri64
Copy link
Member

@miri64 miri64 commented Aug 8, 2018

Contribution description

Fixes some conversion errors caused when compiling with LLVM/clang

Issues/PRs references

Detected in #9398

@miri64 miri64 added Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors) Area: pkg Area: External package ports labels Aug 8, 2018
@miri64 miri64 requested a review from kaspar030 August 8, 2018 07:00
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 8, 2018
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 8, 2018
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 12, 2018
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 13, 2018
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 14, 2018
@miri64
Copy link
Member Author

miri64 commented Aug 14, 2018

@kaspar030 @emmanuelsearch ping?

@kYc0o
Copy link
Contributor

kYc0o commented Aug 15, 2018

As far as I can see it's only about casting isn't it?

@miri64
Copy link
Member Author

miri64 commented Aug 15, 2018

Yes, the target type (specific enum) has a smaller value range than the source type (uint16_t). LLVM/clang is throwing an error because of that.

@miri64
Copy link
Member Author

miri64 commented Aug 15, 2018

After talking with @emmanuelsearch I decided to try to get it upstream, however.

@miri64 miri64 closed this Aug 15, 2018
@miri64
Copy link
Member Author

miri64 commented Aug 15, 2018

Oops.

@miri64 miri64 reopened this Aug 15, 2018
@kYc0o
Copy link
Contributor

kYc0o commented Aug 15, 2018

Ok, so you leave this open until you get news from upstream?

@miri64
Copy link
Member Author

miri64 commented Aug 15, 2018

miri64 added a commit to miri64/RIOT that referenced this pull request Aug 16, 2018
miri64 added a commit to miri64/RIOT that referenced this pull request Aug 21, 2018
Alternative to RIOT-OS#9735, as it [includes that fix in upstream][851f4].

[851f4]: jerryscript-project/jerryscript@851f4f0
@miri64
Copy link
Member Author

miri64 commented Aug 21, 2018

Ok, so you leave this open until you get news from upstream?

@kYc0o see #9808.

@miri64 miri64 deleted the jerryscript/fix/conversion-errors branch August 22, 2018 13:25
danpetry pushed a commit to danpetry/RIOT that referenced this pull request Sep 5, 2018
Alternative to RIOT-OS#9735, as it [includes that fix in upstream][851f4].

[851f4]: jerryscript-project/jerryscript@851f4f0
YutongGu pushed a commit to usc-ee250-spring2020/RIOT-EE250 that referenced this pull request Sep 23, 2018
Alternative to RIOT-OS#9735, as it [includes that fix in upstream][851f4].

[851f4]: jerryscript-project/jerryscript@851f4f0
llueder pushed a commit to llueder/RIOT that referenced this pull request Oct 21, 2018
Alternative to RIOT-OS#9735, as it [includes that fix in upstream][851f4].

[851f4]: jerryscript-project/jerryscript@851f4f0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Area: pkg Area: External package ports Type: bug The issue reports a bug / The PR fixes a bug (including spelling errors)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants