Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

examples/default: remove unnecessary dependency to sht11 #9928

Merged
merged 1 commit into from
Sep 13, 2018
Merged

examples/default: remove unnecessary dependency to sht11 #9928

merged 1 commit into from
Sep 13, 2018

Conversation

aabadie
Copy link
Contributor

@aabadie aabadie commented Sep 13, 2018

Contribution description

The examples/default application makefike contains unnecessary inclusion of the sht11 driver module for msba1 and msb430 boards.
But these boards already include this module when saul_default is loaded (see their Makefile.dep). And the examples/default application includes saul_default.

Testing procedure

Build examples/default for msba2 and msb-430 boards and check that sht1x module is built:

make BOARD=msba2 -C examples/default
make BOARD=msb-430 -C examples/default

Issues/PRs references

Maybe #9317

@aabadie
examples:default: remove unnecessary dependency to sht11
18545db 
This module is already included by the boards when saul_default is included. And the default application Makefile include saul_default
@aabadie aabadie added Area: build system Area: Build system Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR labels Sep 13, 2018
@aabadie aabadie changed the title examples:default: remove unnecessary dependency to sht11 examples/default: remove unnecessary dependency to sht11 Sep 13, 2018
kaspar030
kaspar030 approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@kaspar030 kaspar030 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(untested) ACK.

@kaspar030 kaspar030 merged commit 742b6ac into RIOT-OS:master Sep 13, 2018
@aabadie aabadie deleted the pr/examples/default_cleanup_makefile branch September 23, 2018 08:52
@jia200x jia200x added this to the Release 2018.10 milestone Oct 4, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kaspar030 kaspar030 kaspar030 approved these changes

Assignees
No one assigned
Labels
Area: build system Area: Build system CI: ready for build If set, CI server will compile all applications for all available boards for the labeled PR Type: cleanup The issue proposes a clean-up / The PR cleans-up parts of the codebase / documentation
Projects
None yet
Milestone
Release 2018.10
Development

Successfully merging this pull request may close these issues.
3 participants
@aabadie @kaspar030 @jia200x