-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
periph/gpio: support for extension API (part 2) #9958
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
gschorcht
reviewed
Nov 24, 2018
gschorcht
reviewed
Nov 24, 2018
gschorcht
reviewed
Nov 25, 2018
gschorcht
reviewed
Nov 26, 2018
gschorcht
reviewed
Nov 26, 2018
gschorcht
reviewed
Nov 26, 2018
gschorcht
reviewed
Nov 26, 2018
gschorcht
reviewed
Nov 26, 2018
gschorcht
reviewed
Nov 26, 2018
gschorcht
reviewed
Nov 26, 2018
This was referenced Nov 29, 2018
e32d2bc
to
1899754
Compare
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you want me to ignore this issue, please mark it with the "State: don't stale" label. Thank you for your contributions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Impact: major
The PR changes a significant part of the code base. It should be reviewed carefully
State: stale
State: The issue / PR has no activity for >185 days
State: waiting for other PR
State: The PR requires another PR to be merged first
Type: new feature
The issue requests / The PR implemements a new feature for RIOT
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contribution description
This is an implementation of GPIO redirection outlined by my proposal in #9582 (items 5-6) for the periph/gpio interface. In short, it allows other drivers (such as GPIO expanders) to be addressed using gpio_t so that all existent code can easily gain support through those drivers. For non-implementation detail and discussion, please see #9582
At @kYc0o 's suggestion, I am breaking the implementation of #9582 / #9690 into several pieces to make it easier to review. This PR only contains the API redirection code. For the intercept code (part 1) see #9860
Dependencies
This depends on #9860
Testing procedure
A test case is provided that implements a soft-driver for the GPIO extension interface. The test case uses this driver to confirm that interception and redirection of the API call are working properly. This has been tested and is working properly on mega-xplained.
Issues/PRs references
Partially replaces and closes #9190
Implements items 5-6 (redirection) of my proposal in #9582
For implementation of items 1-4 (interception) see #9860
Part of work tracked by #9690