Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

09-coap: use URI with cord_ep register #260

Merged
merged 1 commit into from
Oct 10, 2022

Conversation

miri64
Copy link
Member

@miri64 miri64 commented Oct 10, 2022

The parameter for cord_ep register was changed in RIOT-OS/RIOT#18053 to be a full URI, not just a server name + registration interface. This fixes the specs and tests to reflect that. /cc @Teufelchen1

@miri64
Copy link
Member Author

miri64 commented Oct 10, 2022

To test, make sure that

sudo RIOTBASE="$(readlink -f ../RIOT)" tox -e test -- -k "spec09" --non-RC

succeeds (since they wait for certain events, they may take a while).

Copy link
Member

@maribu maribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK, trusting your testing. Thanks for tackling this!

@maribu maribu merged commit e33890a into RIOT-OS:master Oct 10, 2022
@miri64 miri64 deleted the spec09/fix/cord_ep-uri branch October 10, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants