Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

task-07: use thread_getpid() instead of sched_active_pid #78

Merged
merged 1 commit into from
Jan 27, 2021

Conversation

benpicco
Copy link
Contributor

sched_active_pid should not be used directly and is no longer exported through sched.h.

See https://forum.riot-os.org/t/sched-active-pid/227

Copy link
Member

@miri64 miri64 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK

@miri64
Copy link
Member

miri64 commented Jan 27, 2021

Please rebase to current master

@miri64
Copy link
Member

miri64 commented Jan 27, 2021

Not sure why travis does not pick up this PR :-/

@miri64 miri64 added the bug label Jan 27, 2021
@miri64
Copy link
Member

miri64 commented Jan 27, 2021

It somehow says "Abuse detected" for this PR. What did you do @benpicco 🤪

@benpicco
Copy link
Contributor Author

benpicco commented Jan 27, 2021

I didn't try to exploit Travis, promise 😅

@miri64
Copy link
Member

miri64 commented Jan 27, 2021

Maybe another rebase? :-/

@miri64
Copy link
Member

miri64 commented Jan 27, 2021

Ah, maybe its more about what you didn't do appearently they expect you to login... Another reason to switch over to GithubActions here as well :-/

@miri64
Copy link
Member

miri64 commented Jan 27, 2021

Another reason to switch over to GithubActions here as well :-/

See #79

@miri64 miri64 merged commit c5ac626 into RIOT-OS:master Jan 27, 2021
@miri64
Copy link
Member

miri64 commented Jan 27, 2021

I deactivated the required check for a short while to merge this. This is only a change to the README anyway, so the build tests should not break ;-).

@benpicco benpicco deleted the patch-1 branch January 27, 2021 15:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants