-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github/workflows: add keepalive dummy commit step #103
github/workflows: add keepalive dummy commit step #103
Conversation
For a first test we could change the days to 1 and see if this change works, and then go back to the default... |
🚀 PR preview deployed to https://RIOT-OS-riot-os-org-preview-103.surge.sh |
yes please do that Other than that, I would ACK this. The reasoning makes sense, as apparently just having a daily trigger is not enough (see https://github.com/marketplace/actions/keepalive-workflow#why) |
72a71e1
to
44e7e46
Compare
There, the limit is temporary set to 1 day |
The workflow is failing. It seems that for this to work we need to disable the branch protection in master... |
Mh, is there another solution maybe? |
Do you think this would work for this case? https://github.com/benjefferies/branch-protection-bot |
Here some more detailed guide https://www.turfemon.com/bump-version-protected-branch-github-actions |
Branch protection for workflows seems to be an open issue for GH... community/community#13836 |
As far as I can see, the "include administrators" option does not exist in the recent config, instead there is a new "Do not allow bypassing the above settings" option now, that works similarly, but might not work with that bot (custom roles require Github Enterprise). |
Removed in #113 |
Github disables workflows from repos that have no activity in the last 60 days. This causes our deployment workflow to be disabled. To avoid hitting this limit, we can use the Keepalive Workflow action to add a commit every 50 days. This PR adds the action as a step of
deployment
, which runs everyday.