Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github/workflows: add keepalive dummy commit step #103

Merged

Conversation

leandrolanzieri
Copy link
Collaborator

Github disables workflows from repos that have no activity in the last 60 days. This causes our deployment workflow to be disabled. To avoid hitting this limit, we can use the Keepalive Workflow action to add a commit every 50 days. This PR adds the action as a step of deployment, which runs everyday.

@leandrolanzieri
Copy link
Collaborator Author

For a first test we could change the days to 1 and see if this change works, and then go back to the default...

@github-actions
Copy link

github-actions bot commented Sep 30, 2022

🚀 PR preview deployed to https://RIOT-OS-riot-os-org-preview-103.surge.sh

@leandrolanzieri leandrolanzieri added the CI / Tooling Deals with CI or website tools label Sep 30, 2022
@miri64
Copy link
Member

miri64 commented Sep 30, 2022

For a first test we could change the days to 1 and see if this change works, and then go back to the default...

yes please do that

Other than that, I would ACK this. The reasoning makes sense, as apparently just having a daily trigger is not enough (see https://github.com/marketplace/actions/keepalive-workflow#why)

@leandrolanzieri
Copy link
Collaborator Author

There, the limit is temporary set to 1 day

@miri64 miri64 merged commit b1d1a2a into RIOT-OS:master Sep 30, 2022
@leandrolanzieri
Copy link
Collaborator Author

The workflow is failing. It seems that for this to work we need to disable the branch protection in master...

@leandrolanzieri leandrolanzieri deleted the pr/github_actions/add_keepalive branch October 3, 2022 08:51
@miri64
Copy link
Member

miri64 commented Oct 4, 2022

It seems that for this to work we need to disable the branch protection in master...

Mh, is there another solution maybe?

@leandrolanzieri
Copy link
Collaborator Author

It seems that for this to work we need to disable the branch protection in master...

Mh, is there another solution maybe?

Do you think this would work for this case? https://github.com/benjefferies/branch-protection-bot

@leandrolanzieri
Copy link
Collaborator Author

Here some more detailed guide https://www.turfemon.com/bump-version-protected-branch-github-actions

@leandrolanzieri
Copy link
Collaborator Author

Branch protection for workflows seems to be an open issue for GH... community/community#13836

@miri64
Copy link
Member

miri64 commented Oct 5, 2022

It seems that for this to work we need to disable the branch protection in master...

Mh, is there another solution maybe?

Do you think this would work for this case? https://github.com/benjefferies/branch-protection-bot

As far as I can see, the "include administrators" option does not exist in the recent config, instead there is a new "Do not allow bypassing the above settings" option now, that works similarly, but might not work with that bot (custom roles require Github Enterprise).

grafik

@leandrolanzieri
Copy link
Collaborator Author

Removed in #113

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI / Tooling Deals with CI or website tools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants