-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
riotbuild: add libsdl2-dev:amd64 #241
Conversation
Arg, I think the problem is that the |
Mh, apt does not complain about installing |
Re-running the build doesn't seem to fix it. I will try to reproduce the problem on Monday. Maybe it's because I didn't build the base images. |
I'm adding another re-run here. This kind of error ( |
Failed again. Retrying master to verify my assumption that this is a failure unrelated to the content of this PR. |
I've seen this a couple of times in this repo, usually some retries make CI pass. |
I've opened an issue. It's probably a race in the riot repo that somehow shows here more often. |
Please rebase onto #246 (or master once that is in), that should make the problem go away. |
0b68228
to
f20fc20
Compare
Rebased on master |
Still looks good to me (can't merge due to permission troubles), but one clarification might be due anyway: This was described as blocking RIOT-OS/RIOT#20335, but that is now through. Is this still an issue (and 20335 just had a workaround that can be dropped once this is through), or has this one become moot? |
RIOT-OS/RIOT#20335 was a larger PR. benpicco recommended to blacklist If this PR is merged, we should be able to remove these lines in RIOT and run the tests in the CI: |
I remember when it wasn't possible to install both the 32 bit and the 64 bit version of |
I think the reason this build (and some others) failed was fixed in #246. The current docker image has both versions installed, and a quick test of |
Adds the 64-bit version of libsdl2-dev required for the 64-bit version of native.
Needed in RIOT-OS/RIOT#20335
libsdl2-dev has quite a few dependencies and adds about 190MB to the image.
If this is too much, I could also blacklist
tests_lvgl
andtests_lvgl_touch
for the CI.