Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

murdock-worker: bump git-cache-rs to 0.1.5 #244

Merged
merged 1 commit into from
Feb 13, 2024

Conversation

kaspar030
Copy link
Contributor

@kaspar030 kaspar030 commented Feb 6, 2024

When the initial git cache clone would have a commit specified (--commit HASH), and would trigger the initial clone into the cache directory, the final "checkout HASH" was skipped.

This caused the first dwq worker thread to checkout a branch to fail every job with ./.murdock: not found.

kaspar030/git-cache-rs@0.1.3...0.1.5

@chrysn
Copy link
Member

chrysn commented Feb 7, 2024

Please rebase onto #246 (or master once that is in), that should make the problem go away.

@kaspar030 kaspar030 force-pushed the bump-git-cache branch 2 times, most recently from 1a91abb to a13237a Compare February 13, 2024 08:11
@kaspar030
Copy link
Contributor Author

kaspar030 commented Feb 13, 2024

huh, this was rebased, it still shows fatal error: 'preprocessor_successor.h' file not found?
link

@chrysn
Copy link
Member

chrysn commented Feb 13, 2024

/me facepalms

The 2024.01 release did not yet get the riot-sys fix.

On the "how do we make sure this doesn't happen again" side, I've added a check point to the release check list that'll flag when there are pending commits on riot-sys/-wrappers.

On the "what do we do now" side ... can we backport 002cd42e26e7fbc3140e9d7aa5a1788bfa9f70f9? Even if we don't do a point release (we rarely do), this makes sure the fix winds up on the branch that gets pulled. (I'd PR it myself, but the backport script doesn't work for people whose RIOT clone is not in their user repo).

@kaspar030
Copy link
Contributor Author

can we backport 002cd42e26e7fbc3140e9d7aa5a1788bfa9f70f9?

I guess so.

@kaspar030
Copy link
Contributor Author

I'd PR it myself, but the backport script doesn't work for people whose RIOT clone is not in their user repo

so which PR is that?

@chrysn
Copy link
Member

chrysn commented Feb 13, 2024

RIOT-OS/RIOT#20303

@MrKevinWeiss
Copy link

Or should it just be the one commit?

@MrKevinWeiss
Copy link

Even if we don't do a point release (we rarely do), this makes sure the fix winds up on the branch that gets pulled. (I'd PR it myself, but the backport script doesn't work for people whose RIOT clone is not in their user repo).

I would probably do a point release, maybe after a week if everything is stable.

@kaspar030
Copy link
Contributor Author

While you're here - would you give this an ACK? It's been tested quite a bit on ci-staging.riot-os.org.

@kaspar030 kaspar030 added this pull request to the merge queue Feb 13, 2024
Merged via the queue into RIOT-OS:master with commit 2675d5d Feb 13, 2024
1 check passed
@kaspar030 kaspar030 deleted the bump-git-cache branch February 13, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants